When I add [google_ad:My_Slot_Name] in the node body, the tag is always replaced by this code :

<div id="gam-holder-c" class="gam-holder">
  <script type="text/javascript">GA_googleAddSlot("c", "c");</script>
  <script type="text/javascript">GA_googleFillSlot("c");</script>
  ...
</div>
CommentFileSizeAuthor
#4 ad_filter_does_not_work-1101662-4.patch1.94 KBthomas bosviel
#2 ad_filter_does_not_work-1101662-2.patch942 bytesthomas bosviel

Comments

jcisio’s picture

jcisio commented

Yes, possible. I haven't tested the filter when porting to D7. I'll take a look at this, but not right now.

thomas bosviel’s picture

thomas bosviel commented
Status: Active » Needs review
StatusFileSize
new ad_filter_does_not_work-1101662-2.patch942 bytes

Arguments passed to theme_google_admanager_block() aren't stored in an array. Filter works fine with this patch.

jcisio’s picture

jcisio commented
Status: Needs review » Needs work

Correct, I totally forgot (this is one of the first modules I ported to D7). Thanks for having pointed it out.

But please use the syntax theme('google_admanager_block', ...) instead. Then test. If it works, I'll commit.

thomas bosviel’s picture

thomas bosviel commented
Status: Needs work » Needs review
StatusFileSize
new ad_filter_does_not_work-1101662-4.patch1.94 KB

With theme('google_admanager_block', ...) syntax.

jcisio’s picture

jcisio commented
Status: Needs review » Fixed

Committed. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

hlopes’s picture

hlopes commented
Version: 7.x-2.x-dev » 7.x-2.3
Status: Closed (fixed) » Active

I've ran into this issue using 7.x-2.3, so marking this issue as active.

jcisio’s picture

jcisio commented
Version: 7.x-2.3 » 7.x-2.x-dev
Status: Active » Closed (fixed)

Revert. Nothing left to do here. Just wait for 2.4.