All of my site files are being posted to a TEMP directory "/var/folders/gv/gvfzO1HkFwWMCiLsMACtUU+++TI/-Tmp-/drush_make_tmp_1300815360" but are Not being moved out of the TEMP directory to their final destination.

Comments

monstordh’s picture

monstordh commented

More info:

I've been using drush-make successfully for a few months. This behavior began when I upgraded to the latest stable version (6.x-2.2) of drush-make.

monstordh’s picture

monstordh commented

More info:

Finally displayed the following info…

ckeditor downloaded from                                             [ok]
http://ftp.drupal.org/files/projects/ckeditor-6.x-1.3.tar.gz.
Found makefile: ckeditor.make                                        [ok]
No core project specified.                                           [error]
ckeditor svn --force export %s %s from                               [ok]
http://svn.ckeditor.com/CKEditor/releases/stable/.
cck downloaded from                                                  [ok]

…

Directory not empty:                                                 [error]
/var/folders/gv/gvfzO1HkFwWMCiLsMACtUU+++TI/-Tmp-/drush_make_tmp_1300821180/__build__/sites/all/modules/ckeditor//ckeditor
ckeditor downloaded from                                             [ok]
http://download.cksource.com/CKEditor/CKEditor/CKEditor%203.4.1/ckeditor_3.4.1.tar.gz.
monstordh’s picture

monstordh commented

I've isolated this to the ckeditor failure. If the ckeditor project is commented out, the installation succeeds.

mxmilkiib’s picture

mxmilkiib commented

I'm having the same issue.

ckeditor.make is;

; $Id$

core = 6.x
api = 2

libraries[ckeditor][download][type] = "svn"
libraries[ckeditor][download][url] = "http://svn.ckeditor.com/CKEditor/releases/stable/"
libraries[ckeditor][directory_name] = "ckeditor"
mxmilkiib’s picture

mxmilkiib commented

looks like this problem with the make file. possibly it doesn't remove temp files if the build fails then doesn't like it? oh, also this.

adrinux’s picture

adrinux commented
Title: TMP files not being relocated » TMP files not being relocated on error
Priority: Major » Normal

Yes, it no longer relocates the tmp files if there is an error - so if you get nothing fix the error!

Of course people keep putting make files in their projects...the ckeditor make file was fixed, and at my suggestion also renamed to ckeditor.make.example so it will no longer be automatically run. Will fix your issue if you use the 1.x-dev version of ckeditor module.

At some point when drush_make can deal with multiple declarations of a project/library sanely we can probably have .make files in projects but for now I've been recommending maintainers just add the make files as projectname.make.example.

zzolo’s picture

zzolo commented

Just a quick comment. I get this error when there is no noticeable error in the rest of the make process. This is just last 4 lines of the make process:

openidadmin downloaded from http://ftp.drupal.org/files/projects/openidadmin-7.x-1.0.tar.gz.                                                         [ok]
features downloaded from http://ftp.drupal.org/files/projects/features-7.x-1.0-beta1.tar.gz.                                                         [ok]
Directory not empty: /var/folders/I0/I0mg8buFFmqBWny7qfErw++++TI/-Tmp-/drush_make_tmp_1301943456/__build__/profiles/cfa_base                         [error]
cfa_base cloned from git://github.com/codeforamerica/cfa-drupal-template.git.                                                                        [ok]
zzolo’s picture

zzolo commented

I think my issues is actually related to #947158: Recursive makefiles can cause conflicts

dmitrig01’s picture

dmitrig01 commented

I don't quite understand the error. Can someone explain?

dmitrig01’s picture

dmitrig01 commented
Status: Active » Postponed (maintainer needs more info)
Anonymous’s picture

Anonymous (not verified) commented
Version: 6.x-2.2 » 6.x-2.3
Status: Postponed (maintainer needs more info) » Active

Basically when an error occurs on running drush make, the temporary files are not relocated or removed from the temporary directory.

If you run a make several times & each time it fails; you'll find the tmp files still exist!

To recreate just create a make file with an error in it & monitor the temporary directory

helmo’s picture

helmo commented
Status: Active » Closed (won't fix)

[ Powered by #1115636: Issue Macros and Templates - Drush Make]

Drush make is being merged into drush core (discussed in issue:#1310130: Put drush make in drush core)
This means that the issue queue is also moving. The Drush project has a component called 'Make' for this purpose.

We would like to take this opportunity to leave behind old/obsolete issues, allowing us to focus on a stable make command in core. E.g. one of the major tasks ahead is making more use of the Drush core code for handling downloads and decompression.

If you feel that this issue is still relevant, feel free to re-open and move it to the Drush queue.

More information will be posted on the drush_make and drush project pages.

NOTE: #11 seems like a good summary. When an error occurs, you can debug it with the tmp files to look at. Otherwise a broken system might be deployed.... or even overwrite a good platform tree.