Needs review
Project:
Notifications
Version:
6.x-2.3
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
22 Mar 2011 at 19:02 UTC
Updated:
19 Jun 2012 at 18:57 UTC
Jump to comment: Most recent file
Comments
Comment #1
christianchristensen commentedPatch correction...
Comment #2
christianchristensen commentedPatchfile for drush make.
Comment #3
christianchristensen commentedAnother quick update - include an array_filter on the provided defaults to filter out the non-defaults.
Comment #4
travist commentedFound an issue with the patch above. It is possible to fall into an infinite function recursion if the user does not have a send_method already defined in their settings. This patch is better.
Comment #5
christianchristensen commentedNice catch travist! That patch is indeed better (but, I think it still provides the flexibility to messaging is now able to ease into multiple endpoints)
Comment #6
pdrake commentedFixed a couple of logic errors. See attached. Thanks for the help on this travist.
Comment #7
pdrake commentedSlightly fixed version of the above patch.
Comment #8
travist commentedHad to pull in the patch from #1075862: Notifications queuing adds a lot of time to node/comment inserts into this because it was causing a conflict. Here is a re-roll with that patch included.
Comment #9
travist commentedApparently, a previous patch removed a portion of the original. Here is the updated patch.
Comment #10
travist commentedChanged a variable to control the queue immediate flag.
Comment #11
travist commentedChanged this patch back to the original by removing the reference to #1075862: Notifications queuing adds a lot of time to node/comment inserts since it really doesn't apply here.
Comment #12
christianchristensen commentedUpdated this patch to be cognizant of notification_lite enqueue options with multiple send methods.
Comment #13
christianchristensen commentedClean up whitespace diff