The settings form from the domain_conf module only supports two caching modes, normal and disabled. If using Pressflow and a reverse proxy such as Varnish the caching mode should be external.

If the user submits the domain_conf settings form for a domain the cache variable is reset to normal and it is not possible to go back to external mode. This prevents Varnish from caching requests.

The attached patch adds the external caching mode and page_cache_max_lifetime settings to the domain_conf settings form when using Pressflow.

Comments

agentrickard’s picture

Status: Needs review » Needs work

Node Access modules do not support external caching, AFAIK.

Please prove otherwise.

mstrelan’s picture

I am fairly new to this Varnish/Pressflow thing, but from my understanding the caching only works for anonymous users. As soon as the SESS cookie is created you no longer have Varnish cache. Drupal 6 by default creates the session cookie straight away, that is why you need PressFlow or Drupal 7 which will lazy-load the session when it is needed. Since all anonymous users are equal until a session variable appears you should be able to safely cache these page visits from anonymous users. Therefore +1 on the patch from me, but would probably be useful getting an expert (eg someone from FourKitchens) to review it.

agentrickard’s picture

Category: bug » feature
Status: Needs work » Needs review

I think that is correct as well.

Yoshi’s picture

StatusFileSize
new1.26 KB

Updated to work with drush make (strip = 1).

:)

agentrickard’s picture

Status: Needs review » Reviewed & tested by the community

@Yoshi

I will assume that means the patch works for you?

Please mark such issues RTBC or they never get committed.

agentrickard’s picture

Status: Reviewed & tested by the community » Fixed

Committed to 6.x. There is no Pressflow for 7 yet, so I don't know how this will affect the patch.

Re-open if / when needed for 7.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.