As the title says, authenticated users are seeing "edit reply edit reply" on each of their own comments in the forum. For comments that they have not written themselves, it is "reply reply".

My administrator user never gets any of these double up. I will try to investigate some more.

Best regards,
Ao

CommentFileSizeAuthor
#7 without-AF.png16.66 KBAonoa
#5 reply-reply.png30.41 KBAonoa
#3 reply-reply.png34.59 KBAonoa

Comments

Aonoa’s picture

Aonoa commented

One of them is styled with only text, while the other has the image given to it from the advanced forum style. Could it be that the text link is from the core forum and the styled one is from advanced forum?

Best regards,
Ao

troky’s picture

troky commented

Please send some screenshots so I can investigate this.

Aonoa’s picture

Aonoa commented
StatusFileSize
new reply-reply.png34.59 KB

Here you go. =)

Best regards,
Ao

EDIT: It is a tif picture file (renamed to upload), seems it won't display here in the browser. Should work fine if you download it.

EDIT2: The post above it with only one reply link, is the topic starter or the thread node if you will. They seem unaffected.

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented

Neither core forum nor advanced forum provide these. The links come from the comment module and AF adds classes to them to style them. I can't think of any way that AF could be duplicating them... You checked that the problem goes away when AF is disabled?

Michelle

Aonoa’s picture

Aonoa commented
StatusFileSize
new reply-reply.png30.41 KB

I made a true png file for you, just in case. =)

I did not try disabling AF to double check, but I never heard about this from my users until I had enabled AF. I will try it just to be sure, though.

Best regards,
Ao

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented

A link would actually be much better than a screenshot. Firebug may give some clues as to the origin of the other link. That or could you paste the chunk of HTML surrounding the links?

Michelle

Aonoa’s picture

Aonoa commented
StatusFileSize
new without-AF.png16.66 KB

I'll see what code is there, but it did indeed disappear when I disabled AF. I'm including a screenshot of a the same comment when AF is disabled.

Best regards,
Ao

Aonoa’s picture

Aonoa commented

With AF:

<ul class="links inline">
<li class="comment-reply first">
<a href="/comment/reply/86/316">reply</a>
</li>
<li class="comment_reply last">
<a class="af-button-small" href="/comment/reply/86/316">
<span>reply</span>
</a>
</li>
</ul>

Without AF:

<ul class="links inline">
<li class="comment-reply first last">
<a href="/comment/reply/86/316">reply</a>
</li>
</ul>

Best regards,
Ao

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented

With no AF, you have an icon by it? What's adding that? If something else is doing a link alter, that could be the problem. Try changing to a core theme and see if the problem goes away.

Michelle

Aonoa’s picture

Aonoa commented

There's two reply links even when using the bartik core theme.

Best regards,
Ao

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented

I've been going through the D6 code and can't find anything that could possibly cause this. I realize this is a D7 issue, so possibly something was introduced in the porting. In D6, however, I can neither reproduce this nor see any way for AF to add another set of links to comments. The only adding of links that it does is on the node not comments.

Could you have a look at the D7 version, troky?

Also, something to port over. At the top of advanced_forum_link is two if tests one right after another. While staring at this code, I realized it made more sense to reverse them to do the quicker check first. See http://drupalcode.org/project/advanced_forum.git/commit/60bc64a . Just a tiny change but saves running through advanced_forum_is_styled() if this isn't a topic starting node.

Michelle

troky’s picture

troky commented

This part of code is much different in D7 so I have to investigate this deeply. Stand by... :)

troky’s picture

troky commented

Ok, I've found the problem. There was class naming change from 6.x to 7.x. In 6.x there was comment_reply class and in 7.x it is comment-reply.

Since link alteration code in 7.x is conformed to 6.x to maintain maximum styles/css compatibility errors like above is possible. I can make some quick fixes but this is not right way to go.

Michelle, I need your permission to change '_' in class names to '-' since that is D7 way and to avoid possible class naming problems in the future. 6.x and 7.x style css is not 100% compatibile already.

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented

Go for it. You really don't need to ask my permission to make changes like that. I'm not going to micromanage your handling of the branch. All I ask is that you talk to me before making major design changes or adding huge features so we're on the same page first. :)

Michelle

troky’s picture

troky commented
Status: Active » Needs review

Changed and committed.
Ao, please check if you still have double links displayed. (clear cache before testing).

Aonoa’s picture

Aonoa commented

It works, thank you so much! =)

Best regards,
Ao

troky’s picture

troky commented
Status: Needs review » Closed (fixed)

Thanks. Closing this.