It appears that upon installing this module, another module, Admin Tools, part of my installation become inoperable. It is (Admin Tools) permanently collapsed and I am unable to expand or make any selections. Since that is more important for my day to day functions, I had to disabled this module... Bummer.... Kinda had high hopes for this...

Comments

realOFF’s picture

Title: Breaks Admin Tools » Conflics with/disables other js functionalities

I must add that upon enabling it, it disables all collapsible-collapsed funcionalities plus some other things as Views tabbing.

deadcyclo’s picture

Same problem here. I think this is because drupal_edit.js fails with error (uncought type error) on pages that don't contain editable fields. The module should only include the javascript on pages that do contain editable fields. (Alternatively, though not as good a solution: fix the script).

deadcyclo’s picture

I've fixed this now. For some reason I cannot clone the git-repo, so I'll just paste what I've done here:

Simply replace the contents of drupal_jeditable.js with:

Drupal.behaviors.jeditable = function(context) {                                                                                                                                                                                               
  if ($('.jeditable-textfield').length) {                                                                                                                                                                                                      
  $('.jeditable-textfield').editable('/jeditable/ajax/save', {                                                                                                                                                                                 
    indicator : 'Saving...',                                                                                                                                                                                                                   
    tooltip   : 'Click to edit...',                                                                                                                                                                                                            
    cancel    : 'Cancel',                                                                                                                                                                                                                      
    submit    : 'Save',                                                                                                                                                                                                                        
    style     : 'display: inline; min-width: 100px;'                                                                                                                                                                                           
  });                                                                                                                                                                                                                                          
  }                                                                                                                                                                                                                                            
  if ($('.jeditable-textarea').length) {                                                                                                                                                                                                       
  $('.jeditable-textarea').editable('/jeditable/ajax/save', {                                                                                                                                                                                  
    type      : 'textarea',                                                                                                                                                                                                                    
    cancel    : 'Cancel',                                                                                                                                                                                                                      
    submit    : 'OK',                                                                                                                                                                                                                          
    indicator : 'Saving...',                                                                                                                                                                                                                   
    tooltip   : 'Click to edit...'                                                                                                                                                                                                             
  });                                                                                                                                                                                                                                          
  }                                                                                                                                                                                                                                            
  if ($('.jeditable-select').length) {                                                                                                                                                                                                         
  $('.jeditable-select').editable('/jeditable/ajax/save', {                                                                                                                                                                                    
     loadurl  : '/jeditable/ajax/load',                                                                                                                                                                                                        
     type     : 'select',                                                                                                                                                                                                                      
     submit   : 'OK',                                                                                                                                                                                                                          
     style    : 'display: inline'                                                                                                                                                                                                              
  });                                                                                                                                                                                                                                          
  }                                                                                                                                                                                                                                            
}

Seems that this module has never been maintained (aka, the creator uploaded it and ignored it afterwards). I'm seriously considering cloning this module and extending it. It has potential, but needs a fair amount of work. This bug has existed for almost a half a year now, and it was trivial to fix.

broncomania’s picture

Thx man for sharing. It works on the first view for me.

Rosamunda’s picture

Status: Active » Needs review
kevin.mcnamee@mailbox.org’s picture

Title: Conflics with/disables other js functionalities » Conflicts with/disables other js functionalities
Version: 6.x-1.3 » 7.x-1.x-dev
Status: Needs review » Patch (to be ported)

Fixed in 6.x-1.x branch.