This patch add some settings to this module, to avoid stats for some roles.

CommentFileSizeAuthor
#3 1102926-Ignore-Roles-3.patch1.24 KBerik seifert
#2 1102926-Ignore-Roles-2.patch1.24 KBerik seifert
#1 1102926-Ignore-Roles.patch1.24 KBerik seifert

Comments

erik seifert’s picture

erik seifert commented
StatusFileSize
new 1102926-Ignore-Roles.patch1.24 KB

Add the patch

erik seifert’s picture

erik seifert commented
StatusFileSize
new 1102926-Ignore-Roles-2.patch1.24 KB

Make a mistake. Here the correct patch

erik seifert’s picture

erik seifert commented
StatusFileSize
new 1102926-Ignore-Roles-3.patch1.24 KB

Please forgive me ;- ). I am not really awake today.

janusman’s picture

janusman commented
Status: Needs review » Needs work

I like this, only some minor style issues, see comments below each code snippet:

+++ b/apachesolr_stats.module
@@ -85,6 +85,13 @@ function apachesolr_stats_admin() {
+  	'#options' => user_roles() ,

2 spaces per tab instead of actual "tab" characters.

+++ b/apachesolr_stats.module
@@ -153,6 +160,11 @@ function apachesolr_stats_exit() {
+  if ( count($test) > 0 ) return ;

ifs need to end with {, newline, then return;, then } on a single line.

If you have time to re-roll, I'd appreciate it. If not wait a bit and I'll do the changes myself.

Powered by Dreditor.

erik seifert’s picture

erik seifert commented

Should be configure my eclipse ;- )

janusman’s picture

janusman commented
Status: Needs work » Fixed

Committed!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.