Like what the title says, using any upload field such as an image or file field causes the Table data to disappear. I have a Table fields, as well as a file and image field in my content type. When creating a node everything seems to be fine, but when I edit a node later, if I do any operations (Upload, remove) on files, such as adding a new image, removing an image, adding a new file or removing one, the data in the table is gone. What's more is that the table itself is completely gone. Only the 'Change Number of Rows/Columns' and 'Import from CSV' options are there. Under Change number of rows and columns both rows and columns are set to 0. I can change those numbers and rebuild the table, but of course there is no longer any data in them.

This seems to be something that is AJAX related, as I can alter alt or title information on an image or file, it's only when I do some AJAX related operation like adding afile or removing one that it causes issues.

CommentFileSizeAuthor
#12 tablefield_rebuild-for-users-no-rebuild-permission_1103020_12.patch4.71 KBvitalie
#4 1103020-ajax-tablefield-4-d7.patch695 bytesfrega

Comments

kevin hankens’s picture

kevin hankens commented

Wow, that stinks, sorry to hear that. I tried replicating it on a new install, but could not make the table data disappear as you describe.

It certainly sounds ajax related, but I'm going to need some more information about your local environment to hopefully replicate.

Thx for the report. Hopefully we can nip this in the bud!

ryan.armstrong’s picture

ryan.armstrong commented

This is up on a cloud slice hosted at www.stormondemand.com. We're running CentOS in you typical LAMP stack. The server is being run by Aegir. Whatever information you need I can provide, let me know what would help you out!

kevin hankens’s picture

kevin hankens commented

What other content related modules are you using?

Also, can you do some debugging using firefox? If you watch the 'net' tab in firebug, you can see the responses. You might be able to see what's happening when an ajax request fires. Otherwise, it's going to be a tough exercise to see what's happening to the form_state when something gets submitted :(

frega’s picture

frega commented
StatusFileSize
new 1103020-ajax-tablefield-4-d7.patch695 bytes

I ran into the same issue. I think i was able to track it down to this line 244ff in tablefield.module:

  elseif ($form_state['submitted'] && isset($items[$delta])) {
    // A form was submitted
    $default_value = tablefield_rationalize_table($items[$delta]['tablefield']);
  }

On an ajax submit, the assumed key 'tablefield' is not properly populated (whilst 'value' is). That - at least on my site - produces said behaviour.
One line patch attached - i don't grok enough of the field/form-API or tablefield.module to really be sure this doesn't create any side-effects, though so YMMV.

ryan.armstrong’s picture

ryan.armstrong commented

I can confirm that this fixed my issue as well! Thanks for the patch frega! Let's roll this in :)

kevin hankens’s picture

kevin hankens commented
Status: Active » Needs review

Nice, awesome work!

I'll give it a whirl and get it committed asap.

I think it's time for a beta!

kevin hankens’s picture

kevin hankens commented
Status: Needs review » Closed (fixed)

Committed and added to beta3 release.

Thanks!!

itserich’s picture

itserich commented
Version: 7.x-2.0-alpha5 » 7.x-2.0-beta5
Status: Closed (fixed) » Reviewed & tested by the community

This patch is missing from Beta 5, and still appears to fix the problem.

Tables are also being deleted when a node is updated via Editablefields, do not know if it is a similar problem. This patch does not fix that problem.

http://drupal.org/project/editablefields

acrollet’s picture

acrollet commented
Version: 7.x-2.0-beta5 » 7.x-2.0-beta6
Status: Reviewed & tested by the community » Closed (fixed)

This issue appears to have been fixed in beta6.

eugis’s picture

eugis commented
Version: 7.x-2.0-beta6 » 7.x-2.4
Issue summary: View changes
Status: Closed (fixed) » Active

Hi all,

this problem still was found in 7.x-2.4 version. It happens only if user don't have "rebuild tablefield" permission ("Restrict rebuilding to users with the permission "rebuild tablefield"" box is on in field settings).

Leeteq’s picture

Leeteq commented
Version: 7.x-2.4 » 7.x-2.x-dev
Priority: Major » Critical

Data loss = "critical".

vitalie’s picture

vitalie commented
StatusFileSize
new tablefield_rebuild-for-users-no-rebuild-permission_1103020_12.patch4.71 KB

Thank you @eugis. Could you help in testing the attached patch?

  • vitalie committed 2ee3069 on 7.x-2.x 
    Issue #1103020 by frega, vitalie: Using any upload field such as an...
vitalie’s picture

vitalie commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.