Another Permission - View Own Time Sheet Entries

Thanks for the *many* patches! =P I'll add this in the next commit.

I just read through the patch more carefully. Should the time sheet not just use the new time tracker permissions to decide whether or not you can view other peoples time sheets? It would be strange if you don't have the 'view all time tracker entries' permission, but can still 'view all time sheet entries' don't you think?

This has been committed to the dev version of Time Tracker. Atrium features have also been updated to match the changes (in case anyone reading this is using the atrium features from github)

It seems that there is a problem with the open Atrium feature.
I downloaded the dev version of Time Tracker and the Atrium features

time_tracker-6.x-1.x-dev
fuseinteractive-Atrium-Time-Tracker-e1599e2

I ran update.php that changed one of my tables (I was on time_tracker-6.x-1.0-beta1 before that)

I also enabled the new permissions despite I am the administrator of the site. Now I get.

warning: call_user_func_array() expects parameter 1 to be a valid callback, function 'time_sheet_view_access' not found or invalid function name in /home/osinetwo/public_html/pm.osinetwork.org/includes/menu.inc on line 452.

When I enable the Atrium-Time-Tracker.
Atrium-Time-Tracker is not available in the features list as well.

You're getting that error because you don't have the time_sheet module turned on. That was my fault, sorry! I changed the atrium feature to check for the time_sheet module before using that callback function. Try downloading the atrium feature again and let me know if it works.

Secondly, the feature doesn't show up in the features list because it doesn't actually have any 'features'... I guess it's more just a module than a feature. If you look at the module it's just a few theme function overrides and a couple drupal hooks.

Hope this helps!

fixed

I have the same error with the time_sheet module turned on

edit:
changing

function atrium_time_tracker_menu_alter (&$items) {
  if (module_exists('time_sheet')) {
    $items['time_sheet/%currentuser'] = array(
      'title' => 'Time Sheet',
      'description' => 'My Time Sheet',
      'page callback' => 'time_sheet_page',
      'page arguments' => array(1),
      'access callback' => 'time_sheet_view_access',
      'access arguments' => array(1),
      'type' => MENU_NORMAL_ITEM,
      'menu_name' => 'features',
      'options' => array(
        'attributes' => array(
          'class' => 'time_sheet_link'
        ),
      ),
    );
  }
}

to

function atrium_time_tracker_menu_alter (&$items) {
  if (module_exists('time_sheet')) {
    $items['time_sheet/%currentuser'] = array(
      'title' => 'Time Sheet',
      'description' => 'My Time Sheet',
      'page callback' => 'time_sheet_page',
      'page arguments' => array(1),
      'access arguments' => array('view time sheet entries'),
      'type' => MENU_NORMAL_ITEM,
      'menu_name' => 'features',
      'options' => array(
        'attributes' => array(
          'class' => 'time_sheet_link'
        ),
      ),
    );
  }
}

in atrium_time_tracker_module fixed the problem for me

@Jelle_S

You shouldn't be getting that error. Are you sure you're using the dev version of time_tracker?

I just tested everything on a fresh install of Atrium and it's working fine. Closing this issue again.