http://drupal.org/coding-standards#naming

CommentFileSizeAuthor
#4 camelCase-1103716-4.patch25.79 KBaaron
#1 1103716_camelCase.patch22.44 KBJacobSingh

Comments

JacobSingh’s picture

JacobSingh commented
Status: Active » Needs review
StatusFileSize
new 1103716_camelCase.patch22.44 KB

I think the magic getter setter stuff is not taking advnatage of PHP5s magic get and set properly and is also a lot of extra code. This patch doesn't seek to fix that, but it at least reduces the redundancy in the StylesDefault constructor.

effulgentsia’s picture

effulgentsia commented

subscribe

aaron’s picture

aaron commented

still reviewing. it breaks style ui previews; i'll see if i can fix that as well.

thanks, @JacobSingh!

aaron’s picture

aaron commented
StatusFileSize
new camelCase-1103716-4.patch25.79 KB

OK, the following works off that patch and fixes the rendered output. I also rolled in a fix to honor thumbnail links when set.

aaron’s picture

aaron commented
Status: Needs review » Fixed

ok, I've committed that change. Thanks, @JacobSingh!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.