When creating an "Example Color RGB"-field, the widget "RGB value as #ffffff" is missing a label.
Attached patch resolves this issue.

Comments

Status: Needs review » Needs work

The last submitted patch, field_example.add-title-on-text-widget.patch, failed testing.

adriaanm’s picture

StatusFileSize
new687 bytes

Updated patch.

adriaanm’s picture

Status: Needs work » Needs review
StatusFileSize
new687 bytes

Status: Needs review » Needs work

The last submitted patch, field_example.add-title-on-text-widget.patch, failed testing.

tr’s picture

Version: » 7.x-1.x-dev

Closed #1035782: No labels appear for example field as a duplicate - it has a good visual description of the problem and was actually the earlier bug report, but this issue has a patch so I'm going to leave this one open.

@adriaanm: Your patch is failing for two reasons. First, it has DOS line terminators instead of Unix line terminators. Second, the patch should be made from the root directory of this module. The filepaths in your patch look like trunk/sites/all/modules/contrib/examples/field_example/field_example.module where they should look like a/field_example/field_example.module (for a -p1 patch) or field_example/field_example.module (for a -p0 patch).

tr’s picture

Issue tags: -widget, -label

Untagging.

adriaanm’s picture

Status: Needs work » Needs review
StatusFileSize
new560 bytes
tr’s picture

Status: Needs review » Needs work

This patch works to solve the original problem! However, I noticed two additional, related problems when I tested this fix:

1) The field help text that should show up on the node/%/edit form does not show up. The help text is set on the same form where you set the label. In my test case, I added the field to the "article" content type so this form is at admin/structure/types/manage/article/fields/field_example
2) If you add more than one of these field_example fields to the content, the field default value (again set at the same place as the label) only affects the first instance of the field.

I suspect the fix for both of these will be very similar to the above fix for the missing label. Can you look into that and make a new patch to fix all these issues?

justafish’s picture

Status: Needs work » Fixed

I've tested all the issues mentioned here for all the widget types (label, help text and default values) and they all appear to have been fixed elsewhere.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.