It's possible to create really wide tables in the preview. In fact, while experimenting or playing, it's really easy. Just add a lot of fields and use the table style, and bam, very wide view.

Once this happens, the UI will bust out because the table pushes the entire page wide. I think, if we can, we need to separate them so the elements that control the width of the main UI are not affected by the width of the preview.

Comments

dawehner’s picture

Some irc comments


[22:46] <dereine> would you support a more old ui like behaviour?
[22:46] <dereine> currently the preview is runned when you load the edit view page
[22:46] <dereine> so that non-js users can use it
[22:47] <esmerel-laptop> run :)
[22:47] <dereine> the issue with this is that you can't change your view once you have saved a broken sql query
[22:47] <dereine> because the interface doesn't load at all
[22:47] <merlinofchaos> Oh. That's bad.
[22:47] <dereine> in d6 this was fixed by always use js/an additional page for non-js
[22:47] <merlinofchaos> I would support reverting to the older behavior.
dawehner’s picture

StatusFileSize
new9.11 KB

This is the current progress.

Things which aren't working

* the preview with #ajax :) It seems to load the wrong path via js
* the css is different.

dawehner’s picture

StatusFileSize
new11.73 KB

Hey now we are back to a fapi caching proble.

Apply the patch, clear cache and click the preview button.
You will see a message because $view is empty in it.

dawehner’s picture

StatusFileSize
new11.82 KB

Okay got preview work again.

Things which has to be done:

* Visit the @todo's
* Fix the css based on the changed html structure
* Fix display of views-preview-buttons/checkboxes

dawehner’s picture

[23:10] <dereine> just fixing the css issues raise the amount of action by factor 2x
[23:11] <dereine> so the problem is: the h1/messages"Modify the display(s) of your view below or add new displays."/buttons are part of the edit form
[23:11] <dereine> but the preview isn't part of the edit form
[23:11] <dereine> so you are kind of lost with with the current level of wrapping

Not sure whether this makes 100% sense.

dawehner’s picture

One thing which should be done here as well is to remove the pre_render thing for a view.

Currently the messanges from excepctions aren't rendered on the initial non-js preview.

merlinofchaos’s picture

Status: Active » Fixed

Finished this up and committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.