While a consistent GUI and workwise is important for such a CMS as Drupal I would like to make this task a must have!
I was tend to set the 'priority' to critical because I think that consistency _is_ critical for a project like drupal.

Let's hope that we could make drupal look the same and make a more standardized workflow..

CommentFileSizeAuthor
#5 active-help-messages-consistency.patch54.28 KBStefan Nagtegaal
#2 system-module-inconsistency.patch655 bytesStefan Nagtegaal
#1 node-modules-inconsistency.patch6.89 KBStefan Nagtegaal

Comments

Stefan Nagtegaal’s picture

Stefan Nagtegaal commented
StatusFileSize
new node-modules-inconsistency.patch6.89 KB

The patch brings up a little more consistency in the node modules (blog, forum, and story.module). Ie:
- make the helptext under the 'Explanation or submission guidelines', more the same (blog & story);
- makes the form_set_error() consistent when the body of a blog/story does not match or exceeds the specified minimal numer of words.
- used the $options for form_select() and form_radios() inline like we do in the rest of drupal;
- Made the textarea sizes for the submission pages the same for all nodetypes and also for the 'Explanation or submission guidelines';

This patch exceeds this bug report/feature request

Stefan Nagtegaal’s picture

Stefan Nagtegaal commented
StatusFileSize
new system-module-inconsistency.patch655 bytes

Function system_settings_form() is used to return the submit buttons ('Save configuration' and 'Reset to defaults') on the '_settings' pages.

If there is no $form present, we should not return the submit buttons.
(This is happening when the taxnomy.module is disabled and the forum.module is enabled. We get a nice error message at the forum settings page, but the submit buttons are also displayed, which shouldn't imo)

dries’s picture

dries commented

Committed the first patch. The second needs a bit more thought.

Anonymous’s picture

(not verified) commented

What is wrong with the second patch, Dries?

Stefan Nagtegaal’s picture

Stefan Nagtegaal commented
Priority: Normal » Critical
StatusFileSize
new active-help-messages-consistency.patch54.28 KB

Patch for making the menu_get_active_help()-text consistent inside drupal. With this patch applied every helptext is put between <p>...</p>, like it should..

Please review and apply!

dries’s picture

dries commented

What do you guys think about this?

drumm’s picture

drumm
he/him
Location NY, US
commented

These should probably be separate issues.

#2: is there an example of an empty form being passed to that function anywhere?

#5: +1

Stefan Nagtegaal’s picture

Stefan Nagtegaal commented

If there is no $form present, we should not return the submit buttons.
(This is happening when the taxnomy.module is disabled and the forum.module is enabled. We get a nice error message at the forum settings page, but the submit buttons are also displayed, which shouldn't imo)

moshe weitzman’s picture

moshe weitzman commented
Priority: Critical » Normal

re: #5. I find it clutterring to add P tag around all help texts. The theme can add these tags, or maybe when we invoke the help hook.

a critical problem is one where your site does not work at all. this is non criticial.

Steven’s picture

Steven commented

We should indeed add <p> tags to all help text. This is because there are multi-paragraph help texts in drupal: they each contain multiple <p> tags. The single-paragraph helps don't at the moment. If the theme were to add <p> tags, then it could only do that for single-paragraph help texts, and this would require some logic.

So definitely +1 on requiring <p> tags everywhere.

killes@www.drop.org’s picture

killes@www.drop.org commented

Does not apply anymore. Smaller patches might be better ;)

Stefan Nagtegaal’s picture

Stefan Nagtegaal commented

Patch was committed a long tiome ago...