Support for multiple TLA XML keys (sections) per site
Christoph C. Cemper - January 18, 2007 - 13:21
| Project: | Text Link Ads Integration |
| Version: | 5.x-1.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Description
I need the TLA module to support multiple ad sections per site, currently only ONE xml key is foreseen.
However if you say want to sell ads on you homepage and one or more important subsections, you will get multiple XML keys from them, and therefor the module also has to create multiple ad blogs (with url restrictions etc) to use those
also, I'm ready to get into the code and help out with implementation
best,christoph
#1
This won't be implemented by me, so I'm marking to "won't fix". If you wish to have this functionality and can either write the code or sponsor it, I will help you as best I can.
#2
Hey Robert,
I'm interested to do this in the next weeks... can you assign this to me?
how about committing? can you assign me CVS access ?
best, christoph
#3
plan to do this
#4
I want to base changes for this feature on a 5.x version... anything in sight?
#5
I believe there is a D5 version in sight. I'm waiting on final confirmation from TLA to go ahead with it.
I'll review your patches and commit them myself. Please feel free to contact me if you run into problems while developing.
#6
As I mailed I won't have time to implement this and I'm helping myself with hand-coding
those multi-page ads with the PHP plugin that TLA offers,
So I contacted Patrick Gavin/CEO of TLA to sponsor that feature in their own interest.
He "cc’d our Drupal developer so he can see about adding this functionality as he is working on the next release"
to Robert, so I'm expecting them to fund this feature.
#7
*Subscribe*
Has there been any progress on this?
#8
Here's a simple modification that provides ability to support multiple TLA inventory - I haven't tested the Feedvertising (RSS feed) feature, and I don't think it works so I'm not sure what to do in this area.
I would appreciate it if someone could review this patch and provide feedback - I definitely took the simplest approach I could take in solving this problem in order to expedite development, but I think the basic functionality is sound (minus the RSS feed support which is not tested and not expected to work).
This patch provides a simple method of of specifying multiple inventory keys: as a comma-delimited list in the admin/settings/textlinkads page.
A block is provided for each key entered - each block will have the associated inventory key in the name - example: "TLA Block For Key = xxxxxxxxxx" and you can set the block visibility in the usual way, so that each block is only visible on the URL that the inventory key is tied to. (since the TLA xml inventory data doesn't specify the target URL for the inventory, I can't do this automatically, as far as I know)
In any case, here's the patch if anyone is interested. All constructive feedback is appreciated.
#9
I neglected to mention that the patch required addition of a new column in the textlinkads table, so the install code needs to be patched before this is ready for prime time.
The new column is 'inventory_key'
and an index based on that key
Here's my current table definition:
CREATE TABLE `textlinkads` (`tlid` int(11) NOT NULL auto_increment,
`url` text NOT NULL,
`text` text NOT NULL,
`beforetext` text NOT NULL,
`aftertext` text NOT NULL,
`rsstext` text NOT NULL,
`rssbeforetext` text NOT NULL,
`rssaftertext` text NOT NULL,
`inventory_key` text NOT NULL,
PRIMARY KEY (`tlid`),
KEY `inventory_key` (`inventory_key`(32))
) ENGINE=MyISAM DEFAULT CHARSET=utf8;
Open to suggestions for better / more correct indexing as I did not spend a lot of time trying to determine optimal data type/indexing strategy (it's expected to be a small table, after all...)
#10
Update of inactivists patch:
1. Made the db change a real install/update_2 query so that the upgrade path is handled
2. Updated the help text to make it more clear - I had major problems because I entered my keys like "KEY1, KEY2" and that extra space caused the page to not be found...
3. Fixed the help text to use ! instead of % which allows the link to actually work
Otherwise, the code works for me in general. Note that my patch is agains 5.x-1.x-dev. The original patch mostly applied with lots of offsets - I imagine that's from 4.7 vs. 5.x differences.
#11
note, there's a typo in the .install of my patch in the textlinkads_install function:
inventory_key varchar(256 NOT NULL,should be
inventory_key varchar(256) NOT NULL,#12
subscribe
#13
Rather than just subscribing perhaps you could test this patch.
kbahey told me that if I was happy with the code I could commit it, so if someone else reviews what I've done and can confirm that it works without side effects I will commit it.
#14
I'm testing out the multiple TLA module patch right now. It seems to be working well for me so far. I'll report back in a few days to let you know how it goes.
#15
I can now confirm that this patch works (when the typo in comment #11 is corrected). I sold an ad on my new page specific Text Link Ads key this week in addition to the ads that I already had on my homepage. I haven't experienced any problems that I have noticed so far.
Thanks for adding this new feature to support multiple TLA keys. You've just added to my income sources!
#16
I just committed this to the DRUPAL-5 branch. Thanks for the initial inspiration (inactivist) and for the testing and reviews.
#17