Closed (fixed)
Project:
Wordfilter
Version:
master
Component:
Code
Priority:
Critical
Category:
Task
Assigned:
Reporter:
Created:
18 Jan 2007 at 13:25 UTC
Updated:
3 Jul 2007 at 12:46 UTC
Jump to comment: Most recent, Most recent file
Will there be a 5.0 version of this module?
| Comment | File | Size | Author |
|---|---|---|---|
| #17 | wordfilter_5upgrade.patch | 14.99 KB | add1sun |
| #15 | wordfilter5.patch | 1.05 KB | v1nce |
Comments
Comment #1
Anonymous (not verified) commentedha. forgot about this module.
i guess I better do that..
thanks for the post. :)
can't give ya an eta though :P
Comment #2
moshe weitzman commentedfilter system received zero changes so will be an easy port.
Comment #3
Anonymous (not verified) commentedk.. this should happen soon. still no eta.
Comment #4
genemcc commentedtracking
Comment #5
Anonymous (not verified) commentedComment #6
eric-alexander schaefer commentedI am taking it on...
Comment #7
preferred name commentedWill v5 have the option to turn a 'badword' into a
<a href="http://www.example.com/node/1">good word</a>?Everything inside the above code tag is the 'good word'
Comment #8
danroth commentedI'm eagerly awaiting this. It's the only module I had in 4.x that I'm missing in 5.x,
and I'd really love to have it right now.
Thanks to anyone who is undertaking this task!
Comment #9
buddaEric? Steve? Anybody got anywhere with a release for 5.x ?
Comment #10
eric-alexander schaefer commentedI am on it. Sorry for the delay. The filtering is already done, got stuck with the forms, which are quite different in 5.X. I should have something to test by the weekend.
Comment #11
eric-alexander schaefer commentedHere we go.
This is a preliminary version. The filtering works, adding words works. Deleting or editing words does not work yet. The form handling is probably very far from perfect, since I tried to keep most of the original code. Maybe we need to throw away the old form handling stuff and rewrite it. Could someone with more 5.X-forms-experience review the changes, please?
Get it here: http://www.eas-consulting.de/wordfilter-5.x-1.x-dev.tar.gz
Eric
Comment #12
Anonymous (not verified) commentedplease submit a proper patch. Recode whatever you want.. I wont deny that this module needs some work. I did not write it but took over it.
Eric do you want to help maintain this module?
Comment #13
eric-alexander schaefer commentedYes. But it will have to wait until june, at least.
Comment #14
Petec-1 commentedThis in my view is a really essential module. It is great that someone has taken the time to try and make a v5 module of it. It would be really useful if someone could add a delete function to it.
Currently it is really easy to screw up your site if you leave an extra space after one the words you put in. It then applies the filter to every hard space in the website, and you have no undo function!
Please email me (pete.comley@virtualsurveys.com) when a new V5 is written. I'll buy you a virtual beer.
Comment #15
v1nce commentedI've patched Eric Schaefer's version 5 module from post #11 above, so deleting or editing words now works. When a word is being deleted, I added a dbquery() to clear the cache_filter table. I too agree this module probably needs a major code rewrite, perhaps starting from scratch.
--Vince--
Comment #16
v1nce commentedComment #17
add1sun commentedHey there. Don't mean to bogart the work others have done but we upgraded this to 5 for a client (and fixed a nasty bug with the node title option) that is running on a live site fine. I've attached a patch against head.
Comment #18
Anonymous (not verified) commentedPatch looks great.
Commit away!
Comment #19
add1sun commentedcommitted to head and a version 5 branch created.
Comment #20
(not verified) commented