Closed (fixed)
Project:
Feedparser
Version:
4.7.x-1.x-dev
Component:
feedmanager
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
18 Jan 2007 at 14:22 UTC
Updated:
9 Feb 2007 at 02:19 UTC
If for some reason the call to feedmanager_query_feed() fails, usually because SimplePie has likewise failed, to read a valid feed, it returns a value of FALSE. But the return value is not checked and in the following lines, is used immediately to call method get_feed_title() which throws a PHP error.
I suggest the following check:
if ($feed === FALSE) {
// simplepie failed to return a valid feed.
return 'admin/aggregator';
}
Comments
Comment #1
buddaCheck added to the feedmanager_form_feed_add_submit() function. Comitted to CVS.
Comment #2
(not verified) commented