I made this submodule nodejs_config to save the nodejs.config.js file, if there is no write permission, it will display the js object lines so the user can save it, without having to edit it line by line.

Let me know if you all like it, any suggestions are welcome.

CommentFileSizeAuthor
#5 nodejs_config.patch7.29 KBafeijo
nodejs_config.patch7.24 KBafeijo

Comments

Anonymous’s picture

Anonymous (not verified) commented

thanks! will review tomorrow.

afeijo’s picture

afeijo
Primary language Portuguese, Brazil
Location Porto Alegre
commented

I changed it a bit, I added drupal_path() to the default value for Auth Path, to avoid this kind of issue http://drupal.org/node/1086974

ignore the first patch :)

Anonymous’s picture

Anonymous (not verified) commented

ok cool, i'll wait for the next patch before i post a review.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Needs work
afeijo’s picture

afeijo
Primary language Portuguese, Brazil
Location Porto Alegre
commented
StatusFileSize
new nodejs_config.patch7.29 KB

here's the file, I forgot to send it in my last msg
it has a small addition, base_path() to the publishUrl default field

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs work » Needs review

sorry for the delay, review coming soon, i promise :-)

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Fixed

thanks:

http://drupalcode.org/project/nodejs.git/commit/79229ea

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

jyee’s picture

jyee commented
Version: 7.x-1.0-alpha4 » 7.x-1.0-beta1
Assigned: afeijo » Unassigned
Category: feature » bug

In nodejs_config.module, function nodejs_config_form_submit() (line 182) references $file, however, there is no declaration of $file. I suspect that $file should actually be $file_path.

$file_path = drupal_get_path('module', 'nodejs') . '/nodejs.config.js';
  if (!is_writable($file_path)) {
  drupal_set_message(t('It was not possible to write the bellow lines to <b>!file</b>, you need to do it manually.', array('!file' => $file)));

also, below is misspelled.

afeijo’s picture

afeijo
Primary language Portuguese, Brazil
Location Porto Alegre
commented
Status: Closed (fixed) » Needs work

the $path problem has been patched already jyee, git pull to update your files

I will fix the misspelled word, thanks

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs work » Fixed

thanks afeijo.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 79229ea on 6.x-1.x, 7.x-1.x, drupalconlondon, auth-refactor, 8.x-1.x, 8.x-1.x-head by beejeebus: 
    #1105192 by afeijo: add a node.js server config generation page