Drupal Coding Standards

Thanks for the report. Yes, we intend on tidying up the code to align it to the coder module's output.

Coder module aside, the code is excellent. I'm evaluating this for a project I'm working on and noticed the following:

• Very readable code
• Highly themeable
• takes advantage of drupal apis very well
• uses pdo syntax
• has a good set of api functions
• Doesn't offer a lot of hooks, but thats to be expected for a new module

This patch should get maestro up to coding standards at least according to coder module.

Thanks lliss. We'll review this patch for the coding standards.

Thanks @llis, I've committed this patch to HEAD.

New patch should update more recent changes to drupal coding spec.

--EDIT--

With one exception:
maestro_inline_form_api_task.module
Line 130: Using eval() or drupal_eval() in your module's code could have a security risk if the PHP input provided to the function contains malicious code. (Drupal Docs)
eval($taskdata['form_api_code']);

That seemed a little more involved. Figured I'd leave it to those who are closer to the project :)

Hm, not sure why coder wasn't saying anything, but what about class names? UpperCamelCase is in vogue now it seems:
http://drupal.org/node/608152

(tipped off here: http://drupal.org/node/1290658#comment-5791146)

Thanks @calvin, we appreciate any and all help :)

We are as well nervous about the eval function but have added a 2nd level permission that is by default disabled and we provide a clear warning. This module was initially written and released during Drupal 7 alpha and we needed a way to provide export/import of the workflows. It works well but yes, if time permits/client project, we would like to explore/use cTools exportables.

Hi Pat, we will likely leave the class and method names as they are unless someone wants to contribute a patch. I see plenty of large modules like views and ctools that don't use UpperCamelCase or lowerCamelCase standard and still use _underscore convention. Based on your 2nd link and recent comments, the debate continues even in the core devel group. I personally like camelcase and am fine with either using lowercase or Uppercase first letter.

- blaine

Hey Blaine! Awesome that you're interested in ctools -- might be a fun opportunity to tinker with it

And yeah, that CamelCase standard mentioned in the queu caught me by surprise, so I came back to toss it out there :)