By matteo on

Hi all,
Is PHPTemplate theme compatible with 4.5 ?? Where can I download a 4.5-ready version ??
I'm downloading Drupal CVS to my pc, but I could not find it....
thanks a lot
Matteo

Comments

Steven’s picture

Steven commented

PHPTemplate is now a theme engine which must be copied to themes/engines/phptemplate. Then you put your phptemplate-based template under themes/yourtemplate.

andremolnar’s picture

andremolnar commented

I've been managing quite fine without doing this in 4.5. Unless this is new as of today? Or unless I don't have the right version of phptemplate?

I just have /themes/phptemplate/phptthemename...

I did have to apply a patch to have 'local tasks' / tabs to work - but besides that everything works fine. (see the issues page for the patch)

I haven't noticed a new version of phptemplate in its project CVS... Have I been missing something?

andre

adrinux’s picture

adrinux commented

Though you'd need to checkout contributions from cvs to use it, you can see the new stuff via the web though:

the new theme engine

the 'default' theme is now called cleanslate

Those two parts will get you the equivalent of:
the old phptemplate Which appears to be what you are using.
The theme system is fairly backwards compatible so it's not so suprising the old version still works.

What's happened here is that the previous version of phptemplate is still in HEAD, and is still being packaged as CVS for it's project page. The newest version is also in HEAD but isn't being packaged at all. Adrian probably ought to remove the old version from HEAD, but I'm not sure what the ramifications of that would be cvs-wise...

When phptemplate is branched for 4.5 you'll see the new version packaged, but as two separate projects - the phptemplate engine and the cleanslate theme.

Also note that I've added a phptemplate-4.5 compatible theme to cvs:
box_grey
And a style variation based on this (located in theme-styles):
box_cleanslate, a remake of cleanslate based on box_grey

Again these have no project pages because they're new and haven't branched for 4.5 yet, I have some more phptemplate fixes to sort before I do that, hopefully sometime in the next week.

adrinux
adrinux@ntlworld.com

Adrian Simmons
adrinux@anaath.at

andremolnar’s picture

andremolnar commented

Thanks for the info. I will reconfigure my site to use the latest and greatest. Hopefully my .tpl files will still be fine.

FYI I recently posted a patch for a bug regarding URL/path aliasing. Simply a fix to the node_url variable in the node hook. (Forgive the format, I'm new to making contributions in a CVS environment).

http://drupal.org/node/11034

It doesn't look like the bug has been caught in the current version.

andre

Anonymous’s picture

Anonymous (not verified) commented

I've just applied the box_grey theme to my site, and downloaded the latest PHPTemplate files. Configured as mentioned in files.

Themes\Box_grey\
themes\engines\phptemplate\

All looks great except when I hit the Themes page:

index.php?q=admin/themes

and try to select a new theme, or configure the theme.

I get the following error:

Fatal error: Cannot redeclare _phptemplate_callback() (previously declared in C:\...\drupal-cvs\themes\engines\phptemplate.engine:19) in C:\...\drupal-cvs\themes\engines\phptemplate\phptemplate.engine on line 19

Any ideas, help appreciated.

Eric

Jhef.Vicedo’s picture

Jhef.Vicedo commented

Why is that you have two(2) seperate phptemplate.engine files? One in "C:\...\drupal-cvs\themes\engines\phptemplate.engine" and the other in "C:\...\drupal-cvs\themes\engines\phptemplate\phptemplate.engine"... were it should be only one I think (on \drupal\themes\engines\phptemplate.engine).

I think this causes the problem...

Work smarter, not harder!
jeff@digitalsolutions.ph

jhefmv [at] gmail [dot] com
Work smarter, not harder!

Anonymous’s picture

Anonymous (not verified) commented

I had it in one place, then added it when it failed.

Removed it, works great, thanks.

inteja’s picture

inteja commented

I've installed Drupal 4.5.0 RC, moved phptemplate to themes/engines and cleanslate into themes, which works great.

My problem is, I make a copy of cleanslate folder, rename it, then make this the default theme but it doesn't look the same as original cleanslate! Default logo is gone, some block positioning is reverted to Drupal default and footer text is missing, even though specified correctly under administer -> settings -> footer message.

Apart from the theme name these two folders are identical so why don't they look identical? I'm confused!

I also tried the box_grey theme and there are similar issues with that (i.e. doesn't look like supplied screenshot).

What am I doing wrong here?

Brian.

--
Brian.

Steven’s picture

Steven commented

It's possible box_grey has some hardcoded references to the logo and/or stylesheet.

Yasha@spreadfirefox.com’s picture

Yasha@spreadfirefox.com commented

Is there any info as to when PHPtemplate will be officially ready for 4.5?

adrian’s picture

adrian commented

it has been ready for weeks.

I'm tagging it now for 4.5 as we speak , but it still won't do much difference.

The problem is the project module needs to be updated to understand engines.
--
The future is so Bryght, I have to wear shades.