The way this hook was invoked was just trashing any hook implementation messages. If you take an array which already has keys on it you can't properly merge it with += . That will simply discard the 'error' and 'warning' keys of the array returned from invocation.

Proper way of doing this is to use array_merge_recursive(), like in patch attached.

CommentFileSizeAuthor
privatemsg.hook_validate.patch621 bytesfranz

Comments

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

array_merge() should be enough in this case, because we're only interested in merging the most upper level, the inner stuff shouldn't be touched anyway.

Anyway, doesn't really matter, commited to all branches.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.