On a freshly installed site that has nodes but not comments, tracker doesn't show any recent posts for users. The INNER JOIN with node_comment_statistics should be a LEFT JOIN, I believe.

CommentFileSizeAuthor
tracker_join.patch1.55 KBhickory

Comments

geodaniel’s picture

geodaniel commented

I think this is also relevant to Drupal 4.7. We have recently upgraded a site from 4.6 to 4.7, without comment module enabled, which presumably meant that the node_comment_statistics table was never built up properly, and so the INNER JOINs do not work.

killes@www.drop.org’s picture

killes@www.drop.org commented

We should rather add something to the install hook of comment.module which creates a proper node_comment_statistics table than to make an already slow query even slower by moving to a left join.

killes@www.drop.org’s picture

killes@www.drop.org commented
Status: Needs review » Needs work

moving to "needs work".

hickory’s picture

hickory commented

What if you never enable comments.module? Tracker should still work.

killes@www.drop.org’s picture

killes@www.drop.org commented

Maybe do

if (module_exists('comment)) {
query with node_comment_stats
}
else {
query without node_comment_stats.
}

dpearcefl’s picture

dpearcefl commented
Status: Needs work » Closed (won't fix)

Considering the age of this issue with no comments and that Drupal 5 is no longer supported, I'm closing this ticket.