Our version specific engines need an 8.x file. Drush is completely broken on 8.x now. I think these version specific files are working out OK but does anyone really have ideas and initiative to improve our engine system?

Comments

mlncn’s picture

mlncn commented

Agreed that it seems the engines, or not as much of them, have to be version-specific, as for the moment drush site-install for D7 and D8 work on the identical engines, so this seems to be needlessly doubling or tripling where maintenance has to take place.

On the other hand the engines aren't that large. I would look at just factoring out some of their functions? And maybe the messages, but i have no idea how to do the latter.

I would encourage the minor changes necessary to allow devs to run Drush with Drupal 8 in the meantime, started here:
#1111086: Drupal 8 compatibility (for key core contributor commands, starting with site-install)

msonnabaum’s picture

msonnabaum commented

I still need to read up on how they work a bit still, but they do seem quite valuable. It seems like if nothing else we need it to fallback on a default if a version specific file isn't available.

moshe weitzman’s picture

moshe weitzman commented
Status: Active » Fixed

Fixed.

It turns out that the engine system already handles this. It looks up a version specific file (i.e. update_7.inc) and if not present, will use update.inc. So, I renamed all the '7' engines to be version agnostic and now they work for 8.x as well. When an engine has to become incompatible with 7, we can copy it to update_7.inc (for example and always use update.inc for the latest. Hope that makes sense.

I still have to deal with the drupal core compatibility declarations for site-install and others

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.