Table node_comment_statistics is not updated when publishing/unpublishing comments [#1106096]

When a comment is published or unpublished the node_comment_statistics table must be updated by the caller. There's a helper function in the comments module that can do it: _comment_update_node_comment_statistics($nid). This function is not called automatically by the comments module.

Comment	File	Size	Author
#1	1106096-Update-node_comment_statistics-when-a-commen.patch	1.07 KB	dawehner

Comments

Comment #1

dawehner

German

commented 29 March 2011 at 13:48

Status:

Active

» Needs review

Status	File	Size
new	1106096-Update-node_comment_statistics-when-a-commen.patch	1.07 KB

It's not so good that this module doesn't use comment_save,
because it does all the logic for us.

To be fair neither comment_publish_action nor comment_unpublish_action recalculate the statistics, too

Comment #2

stefan freudenberg commented 30 March 2011 at 19:02

Thanks for the patch. Overall the comment module is a bit murky when it comes to publishing/unpublishing. If you change the status to published comment_save_comment() will invoke hook_comment() twice providing update and publish as operation parameter. But if you unpublish a comment that way only the update operation will be invoked.

At first sight it's pretty stunning that the comment actions don't do the job. The idea behind not updating node_comment_statistics in the publish/unpublish operation is that you might publish or unpublish more than one comment of the same node in a mass action and it would be much more efficient to update the node_comment_statistics table only once for each relevant node.