Duplicated Path [#1106330]

Default Persistent URL module is great, but sometimes simple features can become a hard task.
This module called "Duplicated path" comes to solve the problem which disables the ability to have the same path on different groups.
For example, you use Persistent URL with subdomain method to create "pseudo" minisite-per-group. Unfortunately, having an "about" page for each group just does not work.
Using this module (and his dependency "Duplicate path editor") uses Drupal hacks to change the way the URL aliases are being created and used, so in the end, while the URL aliases are different per group, it is possible to use "http://group1.example.com/about" and "http://group2.example.com/about" in the same site !

Sandbox URL : http://drupal.org/sandbox/ranm/1106314

Comments

Comment #1

ranm commented 26 March 2011 at 18:52

Forgot to add instructions :

Instructions
• Install the module
• Set Persistent URL to "subdomain" (or and other method).
• Create new groups with their own PURL value.
• Create new nodes in each group, and give them the same URL alias.

Comment #2

Josh The Geek commented 27 March 2011 at 16:49

Status:

Active

» Needs review

Comment #3

ranm commented 29 April 2011 at 15:50

Anyone please? It's been more than a month (-:

Comment #4

ranm commented 1 June 2011 at 18:52

Component:

new project application

» module

Hi,
It's been more than two months now (-;
Is there any chance this module will be reviewed?

Thanks,
Ran

Comment #5

alexreinhart commented 6 July 2011 at 20:15

Status:

Needs review

» Needs work

I've taken a look through your module for any obvious issues. A few comments:

You don't need the $Id$ lines at the start of files now that drupal.org uses Git instead of CVS.
Your .info file should specify what Drupal version your module works with. Check the .info instructions for Drupal 6.x and Drupal 7.x.
find_purl_string() should be prefixed with your module name like your other functions are, to prevent name collisions.
Speaking of find_purl_string(), you might be able to use parse_url() instead of finicky regexes there.
In duplicated_path_editing.module, you substitute $group->purl right into a preg_replace regex. Is it possible for a user to put arbitrary characters in a purl? If so, the regular expression could be altered to do something malicious. I'd suggest using str_replace() if you can.
You might want to add a README according to the module documentation guidelines.

Otherwise, the module looks pretty good! Code style is generally very good, with nothing obviously wrong. Once you've fixed the above issues, set the status here back to "needs review" and someone will take another look through for you. Sorry about the long delay!