I could create a role name "1", but I couldn't create a role name "0"... response is: "You must specify a valid role name."

CommentFileSizeAuthor
#1 1107408-explicitly_check_if_role_name_is_filled.patch2.73 KBrobertom

Comments

robertom’s picture

robertom commented
Status: Active » Needs review
StatusFileSize
new 1107408-explicitly_check_if_role_name_is_filled.patch2.73 KB
crifi’s picture

crifi commented
Status: Needs review » Needs work

I don't think this should be patched, since the permission of a role with name "0" can be critical for secure conditions in modules. Most developers won't allow for this problem.

wouters_f’s picture

wouters_f commented

I think this issue relates to
http://drupal.org/node/1106744 "0" id's or usernames should just be dissallowed.
The system is not ready for this.

crifi’s picture

crifi commented
Status: Needs work » Closed (duplicate)

So this is a duplicate!

robertom’s picture

robertom commented
Status: Closed (duplicate) » Active

So this is a duplicate!

This isn't a duplicate.

Bug #1106744: explicitly check if username is filled refers to username rather than role.

But I can agree to disable both issues if we would kill "politically" an user "0" with a "0" role ;)

robertom’s picture

robertom commented
Priority: Normal » Minor

Setted priority to minor, because is really minor

crifi’s picture

crifi commented

Okay, sorry! role/user is not the same. I think for consistence reasons it should be closed in only one issue.

Status: Active » Closed (outdated)

Automatically closed because Drupal 7 security and bugfix support has ended as of 5 January 2025. If the issue verifiably applies to later versions, please reopen with details and update the version.