For some reason it's using a semicolon (;) to separate the URL fragments instead of an ampersand (&). Also noticed that the commit hash is shortened which is fine, but it needs to remain the full hash string in the URL.

CommentFileSizeAuthor
#5 0001-webviewer_url_handler-plugin-for-GitPHP-added.patch3.25 KBasanchez75
patch_commit_e273a48a3ffc.patch3.74 KBmarkhalliwell

Comments

marvil07’s picture

marvil07 commented
Status: Active » Closed (works as designed)

Yep, the default behaviour of gitweb is to have one big string as GET paramenter as the filter, just like drupal use /, gitweb use ;.

You always can implement a new webviewer_url_handler plugin to change its behaviour.

markhalliwell’s picture

markhalliwell
Primary language English
commented
Title: Gitweb URL Autogeneration » GitPHP URL Autogeneration
Category: bug » feature
Status: Closed (works as designed) » Active

Ohh... I'm thinking of/using GitPHP (http://xiphux.com/programming/gitphp/) which uses ampersands (like it should be) instead of semi-colons. Would it be possible to include this as an option rather than simply closing this?

marvil07’s picture

marvil07 commented
Title: GitPHP URL Autogeneration » Add a webviewer_url_handler plugin for GitPHP

Sure, patches welcome for the new plugin ;-)

sdboyer’s picture

sdboyer commented

Biiiig +1 for new plugins :)

asanchez75’s picture

asanchez75 commented
Assigned: Unassigned » asanchez75
Status: Active » Needs review
StatusFileSize
new 0001-webviewer_url_handler-plugin-for-GitPHP-added.patch3.25 KB

webviewer_url_handler plugin for GitPHP added

marvil07’s picture

marvil07 commented

Adam has been working today at a local sprint. I hope to get this reviewed in the following hours and get in after it :-)

marvil07’s picture

marvil07 commented
Status: Needs review » Fixed

So, I end up doing one change first on versioncontrol, but after it and tweaking a little the last patch, I end up pushing this on two commits: 7439bfa and bf7c4ae.

Thanks for the new plugin!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 7439bfa on 6.x-2.x, fix-invalid-default-branches, fullsync-memory authored by asanchez75, committed by marvil07: 
    Issue #1108390 by asanchez75, Mark Carver: Added webviewer_url_handler...
  • Commit bf7c4ae on 6.x-2.x, fix-invalid-default-branches, fullsync-memory by marvil07:
    Issue #1108390 follow-up: Several fixes to the initial gitphp webviewer...