Active
Project:
Sky
Version:
6.x-3.9
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
28 Mar 2011 at 19:25 UTC
Updated:
29 Mar 2011 at 11:19 UTC
When working with the fb module, which requires adding a class of "fb_canvas-resizable", I discovered that the Sky theme does not respect the classes added in the page preprocess function, but instead forces _ to -.
function sky_render_attributes($attributes) {
//...
$output = ' '. str_replace('_', '-', implode(' ', $items));
//...
}
This seems a bit odd to me. If I add a class, I do not expect the theme to change it on me.
Comments
Comment #1
Jeff Burnz commentedTough one to change now without potentially breaking BC. This is actually pretty normal for Drupal and is almost a defacto CSS standard to use only hyphens. Honestly I am not tempted to change this mainly because of backward compatibility. Perhaps the fb module (I assume fb stands for facebook?) should adopt normal Drupal coding standards?