Closed (fixed)
Project:
Taxonomy List
Version:
master
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
19 Jan 2007 at 19:40 UTC
Updated:
14 Jun 2007 at 16:43 UTC
Jump to comment: Most recent file
The links to the the terms are manually build.
In function _taxonomy_list_get_table there is:
<a href="'. base_path() .'taxonomy/term/'. $term->tid .'">'. taxonomy_image_display($term->tid, '') .'</a>
This only works if you have search-friendly-urls enabled.
Maybe l() or url() should be used here.
Thanks for this wonderful module
Stefan
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | taxonomy_list_links.patch | 1.15 KB | moonray |
Comments
Comment #1
moonray commentedPatch to fix the links.
Comment #2
BoogieBug commentedPatch was applied. Not yet tested with taxonomy_image.module.
Comment #3
(not verified) commentedComment #4
deavidsedice commentedThis patch is not working with images. I've downloaded today the stable version, and I've seen this:
It prints the code, not the resulting HTML.
Why?
Because you're using the l() function without specify that's HTML in the text.
See the API for l():
http://api.drupal.org/api/5/function/l
Note this:
$html Whether the title is HTML, or just plain-text. For example for making an image a link, this must be set to TRUE, or else you will see the encoded HTML.
I corrected this for my site, changing the code in the line 266 with:
If you want a patch, make me know. (I think this will be enough to repair the bug)
Comment #5
Tom-182 commented@ deavidsedice
Thank you so much, your code works perfectly.