Just for preventing possible duplication of porting work: here's the current version of the nodefamily port to 5.0. It incorporates all the points from the Converting 4.7.x modules to 5.x page, except for drupal_get_form() in lonely_page_node_view(), I have to investigate how to port that one.

Still, it seems to need more work. For example, $form (like in nodefamily_form_alter()) has changed its structure considerably (so it doesn't work very well at the moment), and I haven't reviewed all of the module if it works and/or needs to be ported. Expect a better patch next week or so.

This patch also fixes a lot of apidox. Combining apidox fixes with porting stuff was, in hindsight, maybe not the best idea, because it doesn't benefit the 4.7 version and clutters the patch. Suggestions on how to handle style & docs issues vs. work on "real code" are welcome.

CommentFileSizeAuthor
#7 nodefamily_fix_delete.patch717 bytesjpetso
#3 nodefamily_47to50_try1.diff34.96 KBjpetso
#1 nodefamily.info156 bytesjpetso
nodefamily_47to50_pre1.diff23.78 KBjpetso

Comments

jpetso’s picture

jpetso commented
StatusFileSize
new nodefamily.info156 bytes

And the .info file which I can't include in cvs diff until it's committed to CVS. I'd prefer to avoid calling diff itself, if you don't mind :-§

fago’s picture

fago
Primary language German
Location Vienna
commented

@info file: it's fine so.
@docs: I have no better idea too, just improve it for 5.x - that's the future ;)

As pageroute isn't ported yet, I would say we just remove the pageroute integration in the meanwhile.
Thanks for your work :)

jpetso’s picture

jpetso commented
StatusFileSize
new nodefamily_47to50_try1.diff34.96 KB

Ok, here's an updated version of the patch.
"Release notes":
- Actually works now!
- Pageroute support is removed for the time being (replaced by TODO comments)
- The "Maximum population" setting in the content type settings have been moved to the 'workflow' fieldset. I don't like this, but the content type settings form has no 'buttons' array anymore (instead, each button is a seperate form element) and node_type_form() in node's content_types.inc doesn't set the buttons' weight. Setting the weight of all three possible submit buttons seperately is imho bad, because other possible buttons from other modules would be disregarded in this case. (I'll do a weight fix for the core developers, but 5.0 is out already, so we'll likely have to live with this for some time.)

jpetso’s picture

jpetso commented

Quick link to the bug that practically prevents us from having our own fieldset for "Maximum population":
"Submit buttons in the content type settings lack #weight"

fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs work » Fixed

thanks, committed to 5.x branch and HEAD.

fago’s picture

fago
Primary language German
Location Vienna
commented
Title: Port nodefamily to 5.0 » Port nodefamily to 5.0 - delete relations
Status: Fixed » Active

I just tried to delete some created relations and it doesn't seem to work - no affect.

jpetso’s picture

jpetso commented
StatusFileSize
new nodefamily_fix_delete.patch717 bytes

Seems I was not thorough enough with renaming all the occurrences of type (like in, string of the type name) to typename. Here's the fix.

fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Active » Fixed

thanks, fixed :)

mikemet’s picture

mikemet commented

I am unable to apply patches. When will a replacement module be available?

Thanks

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)