Fresh install of latest dev doesnt appear to be including either the default css file or the custom css file as specified in configuration on checking source.
Also appears to be ignoring the settings for the Printer friendly URL list, have the box unchecked but still displays the list.

Cheers,
Sam

CommentFileSizeAuthor
#2 custom_css-1110046-2.patch939 bytesguillaumev
#1 1110046.patch562 bytesessbee

Comments

essbee’s picture

essbee commented
Status: Active » Needs review
StatusFileSize
new 1110046.patch562 bytes

Patch attached. Checks that the css file being unset isnt actually the css file added via the custom option.

Allows user to still keep their custom css file in their themes directory (previously would be unset).

guillaumev’s picture

guillaumev commented
StatusFileSize
new custom_css-1110046-2.patch939 bytes

This first patch does not work. I'm proposing another one to solve the issue...

garnett2125’s picture

garnett2125 commented
Category: bug » support

Hi guys,

I'm trying to make any css file working on the pdf that is generated by this module but its still not working. I've try with the last patch you gave us guillaumev but no happy end. Does it works on your sides ?

Thanks

essbee’s picture

essbee commented

Well this was all working fine, now I can't get dompdfto render anything but inline css. Just seems to ignore all @imports, I even debugged and checked the $html being passed and the css are their... No idea.

ts145nera’s picture

ts145nera commented

work for me. Thank you

sdsheridan’s picture

sdsheridan
he/him/his
commented

All:

Check out http://drupal.org/node/968016#comment-4404402 . I believe I've solved the issue for 6.x-1.12.

Shawn

essbee’s picture

essbee commented

I went a different route to solve the same problem, which involved removing code rather than adding more.

Currently in print.pages.inc in _print_var_generator() if the page is being sent by email it embeds the CSS. I simply commented out the if statement (lines 196, 206-209) so that it embeds the CSS in all scenarios. This ensures the PDF doesnt even need to download css files.

Possibly worth considering, maybe not for all, but at least for PDF generated pages.

Cheers,
Sam

PixelClever’s picture

PixelClever commented
Category: support » bug

This is definitely a bug report not a support request. I've confirmed the same issue in dompdf and tcpdf in the 6x branch. I suspect it is an issue related to the path to the css file.

P.S. For those posting in the issue queue, you should be aware that changing the status to a "support request" can prevent the issue from getting noticed by the maintainer. Many maintainers (myself included) don't respond to support requests at all.

essbee’s picture

essbee commented

Is there any reason not to go down the embedded CSS per #7?

I think embedding the CSS prior to PDF generation completely solves any of these type of issues. It works well for the email routine so the code is already there - in fact it actually reduces the amount of code overall.

jcnventura’s picture

jcnventura
Primary language English
commented
Status: Needs review » Closed (duplicate)

Duplicate of #1169148: Path to custom CSS not working