The module's admin page atm is misplaced in the 'System' block (admin/config/system), while it would better fit or even belong to the 'People' block (admin/config/people).
Also, a configure-link ist missing on the modules page.

Actually it could even be included within admin/config/people/accounts, but for now I'm fixing at least the obvious to-dos.

CommentFileSizeAuthor
#9 username_check-add_config_screen_link-1110120-9.patch921 bytesfloydm
#5 username_check-add_config_screen_link-1110120-5.patch1.34 KBfloydm
#1 1110120_Move_admin_page_to_People_and_fix_the_infof_file.patch1.26 KBpancho

Comments

pancho’s picture

pancho
Location UTC+2 🇪🇺 EU
commented
Status: Active » Needs review
StatusFileSize
new 1110120_Move_admin_page_to_People_and_fix_the_infof_file.patch1.26 KB

Also, the dependency on core's 'user' module is unnecessary, because 'user' is an obligatory core module.
Here's a combined patch.

rafamd’s picture

rafamd commented

nice improvements...specially the configure link

rafamd’s picture

rafamd commented
Status: Needs review » Needs work

Patch seems to fail to apply to latest dev:

error: patch failed: username_check.info:1
error: username_check.info: patch does not apply

We could also add a description to the module in admin/config/people block, how about: "Configure how often checks happen"

rafamd’s picture

rafamd commented
Title: Move admin page to admin/config/people » Move admin page to admin/config/people and other small tweaks

Adjusting title.

floydm’s picture

floydm commented
Status: Needs work » Active
StatusFileSize
new username_check-add_config_screen_link-1110120-5.patch1.34 KB

Rerolled the patch.

floydm’s picture

floydm commented
Status: Active » Needs review
jasom’s picture

jasom commented

When it will be commited to official dev 7 realase? That last one is almost 2 years old :-)

rafamd’s picture

rafamd commented

Thanks for the patch @floydm, I couldn't apply it though.

Tried both in my local machine and also over simplytest.me

Won't demote to needs work because it could be a problem with my setup, but not being able to apply at simplytest.me is strange still...

floydm’s picture

floydm commented
StatusFileSize
new username_check-add_config_screen_link-1110120-9.patch921 bytes

My apologies, I didn't have the patch pathing right. A new patch that has been verified on simplytest.me is attached.

rafamd’s picture

rafamd commented
Status: Needs review » Reviewed & tested by the community

Code looks good, patch tested ok

gokulnk’s picture

gokulnk commented
Issue summary: View changes

This is a simple enough patch. This will improve the UI/UX any reason for not committing this?

I feel that this should go through.

darrellduane’s picture

darrellduane commented

thanks for pointing this out, I overlooked it. I like it--I will investigate and add it if possible.