Download & Extend

Moving terms in taxonomy tree might delete fields data

Project:Term Fields
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:critical
Assigned:Unassigned
Status:needs review

Issue Summary

The current version (1.x.dev from 21st march 2011) does not remember the value of the field after changing the term of the taxonomy tree

Comments

#1

Status:active» postponed (maintainer needs more info)

Could you please give some detailed information and an example to reproduce the bug?

#2

I sort taxonomy terms with drag and drop method. After change weight in taxonomy tree always I have empty value in additional term fields. I add select box field with two value. I set it in term but after change weight in taxonomy tree I have empty value at this select box field. Drupal 6.20, Term Fields form 21th of March 2011r

#3

Problem is in term_fields_taxonomy function. Always if $op is 'update' you call the function: term_fields_update_record but values is empty.

#4

I solved this problem. At term_fields_taxonomy function after line foreach ($fields as $field) {

i add

if (isset($form_values[$field->fid])){

...

}

#5

Status:postponed (maintainer needs more info)» needs review

Thank you so much, I encountered exactly the same problem in the same use case :
* add a text term_field to one vocabulary
* add values into this field for the taxonomy terms
* reordered my term hierarchy using /admin/content/taxonomy/xx

=> term field values of moved terms are empty

The fix in #4 works => atatched is a patch for those interested

If one more person can test the fix we should move this issue into rtbc status

AttachmentSize
1110388-field-not-saved-when-dnd.patch 8.31 KB

#6

Thanks for your patch. I am currently working on the 2.x branch of this project and will take care of this issue on the related developement. But I do not have the time now to test and fix your patch, sorry for that.
But I hope this will not be necessary thanks to the news module version.

#7

Status:needs review» patch (to be ported)

This bug has been fixed in the 2.x DEV version.
Need now to be backported to 1.x version.

#8

Status:patch (to be ported)» fixed

Ported in the 6.x DEV version. Release coming soon.

#9

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

#10

Title:Problem with moving term in taxonomy tree» Moving terms in taxonomy tree might delete fields data
Priority:normal» critical
Status:closed (fixed)» active

Sorry to reopen this but this is a critical bug.
So please do a new official release.
Thanks!

#11

Status:active» needs review

I would be glad to release the 6.x-2.x version. Would you have some time to test the upgrade to the 6.x-2.x-dev branch on a test environement (a copy of your production Website)?

This is important since I am the only one to have performe some tests on the upgrade.
If the term fields conversion works well for you, I will create a release for the 2.x branch.

#12

Version:6.x-1.x-dev» 6.x-2.x-dev

Hello, I'm testing out the 2.x-dev branch and so far things look good. I was able to set up a textarea field, apply it to a vocab, and then set up a View to show the text in a block whenever someone visits a taxonomy term page. Rearranging the term weights does not seem to cause any data loss.

#13

Did you try to upgrade from 1.x version, with some existing fields?

#14

Version:6.x-2.x-dev» 6.x-1.x-dev

Moving this issue to 1.x, as it no longer affects 2.x.

In general, it's good practice to fix major bugs any recommended release (in term_fields's case, 1.x is the only version with the green light on d.o), as people sometimes don't like using -dev versions on production websites.

#15

Actually I do not intend to maintain the 1.x release when the 2.x will be safe.