Drupal 5.0 compatibility?
Johnyp - January 20, 2007 - 03:32
| Project: | Movie Review |
| Version: | HEAD |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | maartenvg |
| Status: | needs review |
Description
Hey all,
I was wondering if someone is working on updating this module to work with Drupal 5.0? I'm using it on my site and would love to use this module on the 5.0 version of the site.
Any hints on future plans?
#1
I'd like to have a working version with 5.0 very much, too. Before starting to work on a 5.0 port I'd like to know if somebody is already on it. For instance, I made some changes to the audio module, but then I found out the developer was fixing it, and I ended up using the CVS version, with many hours of work just left behind. :(
#2
I'm probably going to use it in my new website, so i'm coverting the 4.7 version to a 5.0 working version. Can't say when it's done, but I'm planning it for today.
Wish me luck ;)
#3
Well, I think it's ready, but I'll try a clean install and do some cleaning up, before I generate a patch for you to try.
I've changed this issue in a task, assigned to me, is that okay?
#4
Found (at least) 3 bugs, which I have to fix first.
#5
And here it is. Please review the code, test it and report back whether the functionality is as it should be. Specifically around the teaser, because I wasn't sure wat the previous format was because it didn't give me a teaser at all.
If it works for everybody, the maintainer of the project (still alive?) can generate a new release.
#6
Would very much like to see this module ported to Drupal 5 so I can still use all my old movie review nodes. :)
#7
Using the latest from HEAD:
-jailshell-3.00$ patch < moviereview_5.x.patch
patching file moviereview.info
patching file moviereview.install
patching file moviereview.module
Hunk #3 FAILED at 124.
Hunk #4 succeeded at 139 (offset -2 lines).
Hunk #6 succeeded at 175 (offset -2 lines).
Hunk #7 FAILED at 474.
Hunk #8 succeeded at 514 (offset -5 lines).
Hunk #9 succeeded at 533 (offset -2 lines).
Hunk #10 succeeded at 569 (offset -5 lines).
Hunk #11 succeeded at 607 (offset -2 lines).
Hunk #12 succeeded at 624 (offset -5 lines).
Hunk #13 succeeded at 725 (offset -2 lines).
Hunk #14 FAILED at 764.
3 out of 14 hunks FAILED -- saving rejects to file moviereview.module.rej
patching file moviereview.mysql
patching file update.mysql