Proper XML escaping for site name [#1110598]

Hi,

Our site name contained some special chars that made the google news xml invalid. So I made a small change that passes the site name through htmlentities. That might help also others since a single "&" char in the site name could make the xml invalid:

$content .= '<n:name>' . htmlentities(variable_get('site_name', 'Drupal')) . '</n:name>';

cheers

Comment	File	Size	Author
#2	googlenews-n1110598-2.patch	421 bytes	damienmckenna
#1	escape-site-name-1110598-1.patch	728 bytes	jaytennier

Comments

Comment #1

jaytennier commented 1 November 2012 at 13:34

Title:	htmlentities for site name	» Proper XML escaping for site name
Version:	6.x-1.4	» 7.x-1.4
Category:	task	» bug
Priority:	Normal	» Major
Status:	Active	» Needs review

Status	File	Size
new	escape-site-name-1110598-1.patch	728 bytes

This is still a problem in the Drupal 7 version so rather than create a new issue I'm just bumping up the version number. Attached is a patch that fixes the issue in 7.x-1.4 and can easily be backported to 6.x. The only difference from the OP's solution is that I'm using check_plain().