In Drupal, local tasks are shown as part of their parent: the main page title is still the one of the parent (e.g. "Administer"), while the selected tab is only present in the page, under the <h1> tag.
This can be confusing, for example when you have multiple local tasks open in separate browser windows/tabs. They will all have the same title and will be impossible to tell apart that way.
In the page, the local tasks are shown as part of the page heading, and the title in the <HEAD> <TITLE> tags should reflect that. For example, if you go to /admin/by-module, the head title should be "Administer › By Module" (Garland themes in the funky arrow). At /admin/user and /admin/user/user, it should be "Users › List". /admin/user/add would be "Users › Add". So, even default local tasks would show their title in the head.
The attached patch implements this cleanly. The head breadcrumb is themed the same as the one in the page, but without HTML tags.
The only exception is when drupal_set_title() is used to override the page title. This happens e.g. on user/123. The menu item is defined for 'user' and has a generic 'user' title. When it is viewed, the title is changed to the account name. In this case, we cannot generate a breadcrumb for the local tasks, as it would simply say "User › View" and "User › Edit".
| Comment | File | Size | Author |
|---|---|---|---|
| breadcrumb-title.patch | 2.72 KB | Steven |
Comments
Comment #1
merlinofchaos commentedI offer a tentative +1 on this patch. I need to install it and make sure it does what it appears to do, but from my read of the code it looks good.
One immediate comment I have though -- on at least one site, I have my phptemplate_breadcrumb actually embedding HTML and doing a few other things. Just doing a straight theme('breadcrumb') is going to cause this to act really strange. There may need to be some kind of context identifier to theme breadcrumb -- or perhaps an entirely new theme that's just for the head title. After all, in phptemplate.engine the head title is constructed from the title as well as the site name -- perhaps theme_head_title could be built to pull that out of phptemplate.engine entirely, add the site name in, and unify that?
Comment #2
keith.smith commentedpatch no longer applies
# patch -p0 < breadcrumb-title.patch
patching file includes/menu.inc
Hunk #1 FAILED at 227.
1 out of 1 hunk FAILED -- saving rejects to file includes/menu.inc.rej
patching file includes/path.inc
Hunk #1 succeeded at 176 (offset 15 lines).
patching file themes/engines/phptemplate/phptemplate.engine
Hunk #1 FAILED at 186.
1 out of 1 hunk FAILED -- saving rejects to file themes/engines/phptemplate/phptemplate.engine.rej
Comment #3
chrisshattuck commentedGreat patch, almost exactly what I was looking for. It would be nice to have the option to display the breadcrumbs in the heading as well (i.e. between the h1 tags).
In regards to the problem mentioned above, the phptemplate.engine file is in a different folder than the other two files. You can either run the patch in both the includes/ and themes/engines/phptemplate/ folders, or you can copy phptemplate.php over to the includes folder, run the patch, and then cut and paste it back into it's original folder.
Comment #4
panchoMoving feature requests to D7 queue. Sorry...
Comment #5
mfer commentedSubscribing. This looks good for usability. Have to follow up in this in D7.
Comment #6
Jaza commentedMoving.
Comment #7
sunAlthough I understand the idea, I don't think the consequences of it would be an improvement.
Right now, your browser window/tab title shows the title of the page you're on -- at least the beginning of it.
With this patch, and e.g., 5 open tabs on admin pages, all you'd see would be "Administration » ...", "Administration » ...", "Administration » ...", "Administration » ...", etc
Furthermore, we'd need a special builder/theme function, as the regular theme_breadcrumb() returns HTML markup and is often overridden/customized by the theme.
IMHO, won't fix.Comment #8
sunSorry, turns out I did not understand the idea. Trying to prevent this for others with a better issue title.
Comment #9
sunDiscussed with @merlinofchaos in IRC.
Very closely related: #996302-3: Pages of local actions don't display local action title as page title basically suggests to also output this info in the page title, not only in the HEAD title. Looks like a nice target for the usability team.
Comment #10
Bojhan commentedah
Comment #23
smustgrave commentedSince there hasn't been movement in 12 years think it's safe to say this can be closed.
If still a valid request please reopen updating issue summary for how it pertains to D10.