Download & Extend
Content Access » Issues

Content access rules integration - missing function

Posted by FiNeX on March 30, 2011 at 3:49pm
Project:Content Access
Version:7.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

Hi, testing the content access rules integration I've found a minor bug.

On content_access.rules.inc, function content_access_list_to_checkboxes() calls _content_access_get_operations_lables($operations) which doesn't exists.

A simple fix would be to remove that call:

  $labels = _content_access_get_operations_lables($operations);

and change the line:

    $checkboxes[$op]['#title'] = t($labels[$op]);

to:

    $checkboxes[$op]['#title'] = t($op);

Thanks for the attention.

Login or register to post comments

Comments

#1

Posted by eosrei on April 24, 2011 at 6:52am
Status:active» needs review

Patch for this change attached.

AttachmentSizeStatusTest resultOperations
fix-labels-1110860-1.patch736 bytesIdlePASSED: [[SimpleTest]]: [MySQL] 32,291 pass(es).View details

#2

Posted by System Message on April 24, 2011 at 7:42am
Status:needs review» needs work

The last submitted patch, fix-labels-1110860-1.patch, failed testing.

#3

Posted by BenK on April 24, 2011 at 5:26pm

Subscribing

#4

Posted by good_man on May 2, 2011 at 12:09pm

re. test failing. #1144510: Fix roles selection in test case

#5

Posted by good_man on May 3, 2011 at 2:26pm
Status:needs work» needs review

#1: fix-labels-1110860-1.patch queued for re-testing.

#6

Posted by good_man on May 3, 2011 at 4:54pm
Status:needs review» fixed

Committed thanks a lot, hope we can finish Rules integration soon.

#7

Posted by System Message on May 17, 2011 at 5:02pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here