Is it possible to change where the webform is printed. If I add fields to the webform content type, it prints the webform as the very last element on the node. Also to be able to do this without going into a template file.

CommentFileSizeAuthor
#10 webform_extra_fields.patch947 bytesquicksketch
#9 form_removed.patch700 bytespwaterz
#8 form_removed.patch668 bytespwaterz
#5 extras.patch890 bytespwaterz
#3 fix_hook_field_extra_fields.patch894 bytespwaterz

Comments

quicksketch’s picture

quicksketch
he/him
commented
Title: Is it possible to change the order of where the form is printed » Implement hook_field_extra_fields() for D7
Category: support » feature

I thought we had already done this, but I'm guessing that our implementation was broken by a change in Drupal 7 at some point. This is possible in D6 through this feature: #598714: Implement hook_content_extra_fields(), but apparently the equivalent hook (hook_field_extra_fields) is not implemented correctly in Webform for Drupal 7.

pwaterz’s picture

pwaterz commented

I will take a look tomorrow and try and submit a patch.

pwaterz’s picture

pwaterz commented
StatusFileSize
new fix_hook_field_extra_fields.patch894 bytes

here is my patch

quicksketch’s picture

quicksketch
he/him
commented
Status: Active » Needs work

Looks like this patch still has a bit of code probably copied from poll.module:

+      'choice_wrapper' => array(

Shouldn't that just be "webform"?

pwaterz’s picture

pwaterz commented
StatusFileSize
new extras.patch890 bytes

woops here yea go.

swentel’s picture

swentel commented

There's another older patch at #1040834: Refactor webform_field_extra_fields() - have marked it as duplicate now.

I'm not sure if the 'form' is needed, because I don't think it does anything right ?

quicksketch’s picture

quicksketch
he/him
commented

I'm not sure if the 'form' is needed, because I don't think it does anything right ?

A good point swentel, I think we can remove that since Webform doesn't add anything to the node form.

pwaterz’s picture

pwaterz commented
StatusFileSize
new form_removed.patch668 bytes

make sense here is the revised patch.DONT USE THIS ONE. Php error

pwaterz’s picture

pwaterz commented
StatusFileSize
new form_removed.patch700 bytes

Use this one.

quicksketch’s picture

quicksketch
he/him
commented
Status: Needs work » Fixed
StatusFileSize
new webform_extra_fields.patch947 bytes

Thanks pwaterz, I've committed this simplified patch plus removing some legacy code that should no longer be necessary regarding field weights.

pwaterz’s picture

pwaterz commented

sweet!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.