Drupal 7?

First crack at a D7 release of columns_filter. I don't know about the wysiwyg plugin as I use ckeditor which I'll have some integration for in a bit.

I also removed the theme functions for now, but if you just need div separators as is then this will work for you.

Same filter order applies. Keep it just under the 'Limit allowed HTML tags' and you're good.

Thanks for working on this!

Changing status so I remember to look at this when I have time.

Same issue for me. I'll take a look, but i'm not terribly familiar with wysiwyg editors.

I've taken a look at the zipfile.

The code needs a bit more work:

- we've lost a few function docblocks
- Implementation of hook_filter <-- it's not, it's now a callback
- callbacks like _columns_filter_filter can lose the initial _

Also, this should be run through coder module.

I've started a 7.x-1.x branch. Can you post your version as a patch on that please?

Might try porting this tomorrow...

EDIT: Lack of time, will have to wait until next week.

Ok, had a little bit of trouble creating this patch, still getting used to git : ).

Please test, code works well for me.

Applying this patch gives a few whitespace errors:

git apply columns_filter_d7-1111390-7.patch

columns_filter_d7-1111390-7.patch:220: trailing whitespace.

columns_filter_d7-1111390-7.patch:227: trailing whitespace.

columns_filter_d7-1111390-7.patch:242: trailing whitespace.

columns_filter_d7-1111390-7.patch:250: trailing whitespace.

columns_filter_d7-1111390-7.patch:265: trailing whitespace.

warning: squelched 1 whitespace error
warning: 6 lines add whitespace errors.

And this IMHO should be moved into columns_filter.info
(see http://drupal.org/node/171205#stylesheets and system_add_module_assets)

function columns_filter_init() {
  drupal_add_css(drupal_get_path('module', 'columns_filter') . '/columns_filter.css');
}

Other then that I see no problems.

Thanks for the review RandalK! Here's a new patch.

Committed this to the 7 branch and made a dev release which should show up in a while.

I noticed one problem but I've filed it as a new bug rather than held this up as it's minor: #1192148: filter UI description no longer matches core style.

Thanks everyone :)

Also, this: #1192152: review setup instructions for D7.