The mass migration task for platforms fails in Aegir 1.0 RC3

attempted:

curl http://drupalcode.org/project/hostmaster.git/patch/b9ad607f85283a0bbb138... | patch -p1 -R

Doesn't appear to fix the issue. Node Access was also rebuilt several times in the process just to be sure. All led to consistent failure.

Comments

anarcat’s picture

anarcat CreditAttribution: anarcat commented
Priority: Major » Critical

Please be more specific about what fails exactly here.

You mentionned something about the page title being wrong?

EclipseGc’s picture

EclipseGc CreditAttribution: EclipseGc commented

Actually the modal window that pops up says access denied, and on page refresh, you get a title that SHOULD have been in the modal, though the "task name" that you're trying to perform (migrate) is missing from the title.

anarcat’s picture

anarcat CreditAttribution: anarcat commented

I can reproduce, this is the error I get:

warning: Parameter 3 to hosting_migrate_platform_batch() expected to be a reference, value given in /var/aegir/hostmaster-1.0-rc3+extra/includes/batch.inc on line 190.
You are not authorized to access this page.
anarcat’s picture

anarcat CreditAttribution: anarcat commented

Fixing that reference doesn't actually resolve the permission issue, which still stands.

anarcat’s picture

anarcat CreditAttribution: anarcat commented
Status: Active » Fixed

The problem was with the CSRF fix introduced in #1117296: cross site request forgery issue in tasks which I have since reverted. head should work again now.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 1f2d9d9 on 6.x-2.x, 7.x-3.x, dev-ssl-ip-allocation-refactor, dev-sni, dev-helmo-3.x by anarcat: 
    do not check for CSRF attacks on interactive tasks

those tasks are not...

  • Commit 1f2d9d9 on 6.x-2.x, 7.x-3.x, dev-ssl-ip-allocation-refactor, dev-sni, dev-helmo-3.x by anarcat: 
    do not check for CSRF attacks on interactive tasks

those tasks are not...