Vintage

Overall this looks pretty good. In IRC @Heine and I noted a potential issue with passing args. I posted in the project issue queue.

Still needs reviewed before marking as RTBC..

Any news with this?

I seriously dislike this in template.php:

    $body_classes[] = 'tax-' . eregi_replace('[^a-z0-9]', '-', $term->name);

Apart from the fact that ereg was deprecated, I don't want to think about the fact that $term->name is insecure. It is mitigated by the ereg but still, we don't want to open a can of worms

Once this is fixed, I give it RTBC

Rtbc imho

Looks like there is a possible XSS vulnerability - the footer_copyright() does not escape the site_name variable:

  12 function vintage_preprocess_page(&$vars, $hook) {
  13 
  14         $vars['footer_copy'] = footer_copyright();

 471  function footer_copyright(){
 472     $year = '' ;
 473     $time = time () ;
 474     //This line gets the current time off the server
 475     $year .= date("Y",$time);
 476     //This line formats it to display just the year
 477     return t('Copyright ') . $year . ' ' . variable_get('site_name', 'drupal') . '.';
 478 }

Everything is normal priority in this queue.

Tagging for easier finding.

 	// Don't display empty help from node_help().
  if ($vars['help'] == "<div class=\"help\"><p></p>\n</div>") {
    $vars['help'] = '';
  }

That's not a theme's job.

  if (module_exists('taxonomy') && $vars['node']->nid) {
    foreach (taxonomy_node_get_terms($vars['node']) as $term) {
			$body_classes[] = 'tax-' . preg_replace('/[^a-z0-9]/i', '-', check_plain($term->name));
    }
  }

That hits the database, and if you have a $node in the vars, then it already contains the taxonomy terms!
Also, why the preg if you have vintage_id_safe() to hand?

          array_pop($body_classes); // Remove 'section-node'

A lot of work round here just to clean up classes on node add / edit / delete. Is ability to theme those pages so important?

  if ($vars['node']->type != "") {

This bunch of checks needs to be inside a check that node exists.

- Bad indentation in vintage_preprocess_block() and vintage_links()

- Review how you lay out docblock comments -- only one space after the initial * and no blank line before the function declaration.

- vintage_breadcrumb missing docblock

Overall, I'm not sure this qualifies as a *starter* theme... there's a lot in there that I'd find I don't need or would outright have to revert.

Indentation went from bad to worse. Each indent should be 2 spaces. I don't think we need to hold up this application for indentation issues. Several people have looked at this and all of the issues have been addressed. It would be nice if reviewers would follow up.

If they think that the indentation was fixed, it becomes a bigger problem than if it was just wrong.

No activity in several months. Reopen and set the status to "needs review" if you are still pursuing this application.

Patch applied to fix indentation, the issue is most likely that their editor replaced double spaces with \t characters.

The above patch does not fix all of the code formatting problems; check for tabs that should be spaces. Also there was a number of relatively minor formatting issues in your template file. The coder module (drupal.org/project/coder) will help you find the specific formatting issues.

It also appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

Good work though :) Keep at it!

@EricoVinicius has been contacted to ask if the application is abandoned.

After ten weeks with a status of needs work: the applicant may be contacted by a reviewer to determine whether the application was indeed abandoned. The action taken by the reviewer should be documented in the project application issue.

http://drupal.org/node/894256

For #10.

Closing due to lack of activity. Feel free to reopen if you are still working on this application.