Needs work
Project:
Chartbeat
Version:
6.x-1.2
Component:
User interface
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
31 Mar 2011 at 17:12 UTC
Updated:
24 Sep 2014 at 00:19 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
skdrupal88Comment #2
Chaulky commentedI was confused about this issue description until I looked at the code. Instead of entering your User ID and your Domain, this patch has you enter the two javascript snippets provided by Chartbeat. I'm not sure if I prefer this approach over entering your User ID and Domain. Entering the code yourself would make it easier to update it if the JS from Chartbeat changes; you wouldn't have to wait for a new release of the module. But entering the User ID and Domain makes it easier to alter the properties (e.g., override the uid and domain on a testing/development server in settings.php).
Anyone have any comments on these two approaches?
Comment #3
johnish commentedI like cracker's approach to this.
Comment #4
robcolburn commentedChartbeat no longer requires code placed in the header, which is not performant anyway. Taking the code wholesale from Chartbeat provides little to no flexibility on the Drupal side of things. What I mean is, if it's your intention to just copy/paste script in, why bother with a dedicated module? Just have an open region, and copy/paste the code there.
Comment #5
robcolburn commented