I've created a patch that replaces the "User ID" and "Domain" fields on the fields in which to insert code with Chartbeat account.

CommentFileSizeAuthor
#1 chartbeat_fields.patch3.4 KBskdrupal88

Comments

skdrupal88’s picture

StatusFileSize
new3.4 KB
Chaulky’s picture

I was confused about this issue description until I looked at the code. Instead of entering your User ID and your Domain, this patch has you enter the two javascript snippets provided by Chartbeat. I'm not sure if I prefer this approach over entering your User ID and Domain. Entering the code yourself would make it easier to update it if the JS from Chartbeat changes; you wouldn't have to wait for a new release of the module. But entering the User ID and Domain makes it easier to alter the properties (e.g., override the uid and domain on a testing/development server in settings.php).

Anyone have any comments on these two approaches?

johnish’s picture

I like cracker's approach to this.

robcolburn’s picture

Issue summary: View changes

Chartbeat no longer requires code placed in the header, which is not performant anyway. Taking the code wholesale from Chartbeat provides little to no flexibility on the Drupal side of things. What I mean is, if it's your intention to just copy/paste script in, why bother with a dedicated module? Just have an open region, and copy/paste the code there.

robcolburn’s picture

Status: Active » Needs work