Line include : "links_l($display_url, $url, $attribs)"
Even though the links_l function was removed for Drupal 5 release.

I'm not sure what to replace this with.

Another note - when I replaced that with a simple string the next error appears :
warning: call_user_func_array() [function.call-user-func-array]: First argument is expected to be a valid callback, 'links_related_embed' was given in form.inc on line 217.

Is somebody working with links_related on Drupal 5?

Comments

LeDucDuBleuet’s picture

LeDucDuBleuet CreditAttribution: LeDucDuBleuet commented

I just got that same error:
Fatal error: Call to undefined function: links_l() in links_related.module on line 543

This error happens when trying to view/edit a node with "Links Related" information entered.

Unfortunately, I don't believe I know enough on Drupal yet to be of much help...

Anyone has a clue for us?

Thanks!
LDDB

syscrusher’s picture

syscrusher CreditAttribution: syscrusher commented
Assigned: Unassigned » syscrusher
Status: Active » Reviewed & tested by the community

I've committed a fix for this error; thanks for the report.

The fix is in version 5.x-1.3. This is my first commit since the new CVS tagging standards are in place, so please bear with me if I've goofed it up and didn't get it released properly.

Syscrusher

fiLi’s picture

fiLi CreditAttribution: fiLi commented

Thanks for working on it. I downloaded the latest CVS but it won't work.

Can you point me to the 1.3 version?

syscrusher’s picture

syscrusher CreditAttribution: syscrusher commented

I am very sorry -- when I tagged this module in CVS, I didn't realize that I also needed to trigger the release on the Drupal project page. (This is my first release under Drupal's new CVS system.) I have taken care of that this morning. There actually has been another release in the meantime, so watch for version 1.4 rather than 1.3 on the project page when Drupal's batch process does its next update.

Syscrusher

fiLi’s picture

fiLi CreditAttribution: fiLi commented

Thanks.

I tried it again, still not working. Now I get the following error:
warning: call_user_func_array() [function.call-user-func-array]: First argument is expected to be a valid callback, 'links_related_embed' was given in /includes/form.inc on line 217.

Any ideas?

syscrusher’s picture

syscrusher CreditAttribution: syscrusher commented

I'm not seeing the error...can you tell me under what circumstances you are getting this message? I believe you that it's real, but need more information to replicate (and thereby fix) the problem in my test environment. Thanks.

Syscrusher

fiLi’s picture

fiLi CreditAttribution: fiLi commented

The message shows up when selecting "edit links" with an example link : /node/80/links/edit , like on a book page.
I'm running a pretty straightforward Drupal 5 installation. Nothing special.

Weird.

fiLi’s picture

fiLi CreditAttribution: fiLi commented
Version: 5.x-1.2 » 5.x-1.4

On line 595 :
$html = drupal_get_form('links_related_embed', $form);

Where is the links_related_embed function being implemented?

syscrusher’s picture

syscrusher CreditAttribution: syscrusher commented

Ouch...I see it now. That whole menu item is deprecated, and I didn't realize it was still there. That was put in during development before I got the Related Links to successfully edit within the main node edit page. I'll take the offending page out of the code.

Syscrusher