Small fixes in the date.inc file [#1112590]

Comment	File	Size	Author
#12	1112590-12.patch	1.02 KB	ashishdalvi
#7	date_fixes-hrdk.patch	2.01 KB	Hardik C
	date_fixes-btmash-1.patch	2.01 KB	btmash

Comment #2

btmash commented 17 May 2011 at 17:55

I'm a little bit lost - is the patch causing other errors to come up or fixing the issue you are having?

Log in or register to post comments

Comment #3

rfay

he,him

English

Palisade, CO, USA

commented 17 May 2011 at 18:00

Your patch is essential. (I was working on a similar one).

I just put it in CNR.

Log in or register to post comments

Comment #4

Balbo commented 29 August 2011 at 10:25

Project:

Signup

» Date

Shouldn't this patch be in the "date" project?

Log in or register to post comments

Comment #5

Balbo commented 29 August 2011 at 10:28

Project:

Date

» Signup

Ok, sorry for confusion. :-/
I didn't see the /sites/all/modules/signup/includes/date.inc.

Log in or register to post comments

Comment #6

jwilson3

English

Ecuador

commented 1 September 2011 at 20:55

The first part of the patch on this issue is somehow related to #1190944: Notice: Undefined property: stdClass::$language in _signup_date_get_node_scheduler(), which solves an actual error ($node->language, not being defined) which may have been causing the array_push error in the first place, but I'm not totally sure.

The patch on this issue may also solve the same issue by changing the order of the two if statements. I'm not 100% sure of the intended impact of switching the preference from where to grab the date value from, but the fact is $node->language will never be set because the $nodes passed to this function are not real nodes, so if by any chance, it gets past the first if, then it will still fail.

I wasn't experiencing the time-zone issues reported on this thread, so I ask that you also take a look at my issue as well, to perhaps combine forces.