Thanks for the nice LoginToboggan module for D7.

I really like the rules integration. I spent a couple of minutes finding the rules event, till I found it on top of the list. I was looking for a LoginToboggan group first but there was none. This patch adds the missing LoginToboggan group (optgroup) and puts the rule inside. This is just a one-liner but an important one. ;)

CommentFileSizeAuthor
#5 add_rule_into_group.patch544 bytesAnonymous (not verified)
#1 LT_Rules.jpg97.19 KB1sp
add_rule_into_group.patch550 bytesAnonymous (not verified)

Comments

1sp’s picture

Issue tags: +rules, +proposal
StatusFileSize
new97.19 KB

@mikewink i can see the group declaration in the git master already. are you celebrating april 1st on me :P

Nevermind , this actually pulled in a good argument. Shouldn't the LoginToboggan events be in User group ?

Please see the attached image for detail.

1sp’s picture

@hunmonk what do you think on this?

hunmonk’s picture

@sudhirporwal: i don't use rules, so i defer to your judgement on this -- whatever seems like the most sensible place people would look to find it, that's where it should go. :)

1sp’s picture

@hunmonk thanks :) I believe It must go in the User group as it is where normally any user would expect it.

@mikewink can you please re-submit the patch so that the event gets listed in the User group? Thanks for the effort so far !

Anonymous’s picture

StatusFileSize
new544 bytes

Here is the altered patch as you wished my lord. ;) It puts the rule into the user group.

1sp’s picture

Status: Needs review » Fixed

Patch tested and confirmed to work. I have committed it to the source tree.

Status: Fixed » Closed (fixed)
Issue tags: -rules, -proposal

Automatically closed -- issue fixed for 2 weeks with no activity.