Home » Download » Drupal project » Drupal » Issues

Create #confirm property to ensure equality of two input fields

birdmanx35 - January 21, 2007 - 06:47
Project:Drupal
Version:8.x-dev
Component:forms system
Category:feature request
Priority:normal
Assigned:Unassigned
Status:needs work
Issue tags:Novice
Description

Part of a series of reforms for the login system, this patch would ideally provide two e-mail fields to ensure accuracy on registration, a feature that has previously been provided by the LoginToboggan module.

The login functionality applies to all Drupal installs, and this usability feature seems to me to be applicable to all Drupal installs and therefore the 6.x-dev core.

NOTE: I have no coding skills whatsoever, however, I hope I can contribute my ideas and hopes to Drupal.

» Login or register to post comments

#1

Pasqualle - September 16, 2008 - 03:59
Version:6.x-dev» 7.x-dev
Priority:minor» normal
Login or register to post comments

#2

bsherwood - February 1, 2009 - 22:35
Category:feature request» bug report

+1 Subscribing!

Setting this to bug report because I feel this is a security related issue. Almost all CMS systems provide this functionality to make sure users are not creating bad passwords.

Login or register to post comments

#3

karschsp - March 17, 2009 - 04:01

tagging for novice queue

Login or register to post comments

#4

aaronbauman - March 19, 2009 - 19:10
Assigned to:Anonymous» aaronbauman

What about abstracting this to a new property name "#confirm" that can be applied to ANY field?

I will take that on, unless there are objections.

edited for terminology

Login or register to post comments

#5

aaronbauman - March 26, 2009 - 17:43

In this patch:

  • Implementation of #confirm property
  • Simpletests for #confirm property (in modules/simpletest/tests/form.test)
  • JavaScript user feedback ("Confirm values match: yes/no") similar to that of password_confirm FAPI type
  • Basic styling of confirm fields and js user feedback
  • admin/user/settings field to allow admin control over email confirm field on user/register.

Not in this patch:

  • Any changes to password_confirm FAPI field type. The #confirm property implementation has the potential to fully replace password_confirm, but that's not part of this patch.
  • Javascript tests

Feedback welcome -- thanks for reviewing & testing

AttachmentSizeStatusTest resultOperations
111322-confirm-property.patch16.23 KBIdleFailed: Failed to install HEAD.View details | Re-test
Login or register to post comments

#6

aaronbauman - March 26, 2009 - 17:43
Status:active» needs review
Login or register to post comments

#7

System Message - April 4, 2009 - 00:40
Status:needs review» needs work

The last submitted patch failed testing.

Login or register to post comments

#8

aaronbauman - April 13, 2009 - 14:41
Status:needs work» needs review
AttachmentSizeStatusTest resultOperations
111322-confirm-property_0.patch16.21 KBIdleFailed: Failed to apply patch.View details | Re-test
Login or register to post comments

#9

System Message - April 30, 2009 - 01:55
Status:needs review» needs work

The last submitted patch failed testing.

Login or register to post comments

#10

sun - May 5, 2009 - 21:55

+1, subscribing.

Your coding style needs work - please read http://drupal.org/coding-standards and sub-pages about comment standards.

Login or register to post comments

#11

aaronbauman - May 7, 2009 - 19:32
Status:needs work» needs review

rerolled @ HEAD

AttachmentSizeStatusTest resultOperations
111322-confirm-property.patch15.34 KBIdleFailed: 11229 passes, 0 fails, 5 exceptionsView details | Re-test
Login or register to post comments

#12

mcrittenden - May 7, 2009 - 20:06
Title:Provide two e-mail fields to ensure accuracy on registration» Create #confirm property to ensure equality of two input fields
Component:user system» field system
Category:bug report» feature request

Looks like the intent of this issue has changed. +1 for a #confirm property.

Login or register to post comments

#13

mcrittenden - May 7, 2009 - 20:09
Status:needs review» needs work

Bot hasn't finished testing yet but either way it needs a lot of work from the coding standards standpoint, as sun pointed out.

Login or register to post comments

#14

aaronbauman - May 7, 2009 - 21:12

Can you please be a bit more specific w.r.t coding standards?
I ran it through Coder already.

Login or register to post comments

#15

Pasqualle - May 7, 2009 - 22:31
Status:needs work» needs review

reroll, with code style and translation related changes

AttachmentSizeStatusTest resultOperations
111322-15-confirm_property.patch15.39 KBIdleFailed: Failed to apply patch.View details | Re-test
Login or register to post comments

#16

yched - May 7, 2009 - 23:31
Component:field system» forms system

Change component. This is not related to the Field API.

Login or register to post comments

#17

System Message - May 17, 2009 - 04:40
Status:needs review» needs work

The last submitted patch failed testing.

Login or register to post comments

#18

aaronbauman - May 18, 2009 - 13:30
Assigned to:aaronbauman» Anonymous
Login or register to post comments

#21

mcrittenden - September 10, 2009 - 15:47
Version:7.x-dev» 8.x-dev

Guess it's too late for 7.x now.

Login or register to post comments

#22

Aza - September 17, 2009 - 23:37
Version:8.x-dev» 6.x-dev

Is this feature now available in 6.x or have you given up?

Login or register to post comments

#23

mcrittenden - September 18, 2009 - 12:09
Version:6.x-dev» 8.x-dev

Aza: this feature won't make it into 6.x...only bug and security fixes go in at this point, and now that 7.x has reached code freeze, it's not making it in there either, so we can only hope for 8.x at this point.

Login or register to post comments
 
 

Drupal is a registered trademark of Dries Buytaert.