JavaScript: Uncaught TypeError - Cannot call method 'replace' of undefined [#1113550]

If a user doesn't list input anything in the top level domain list field then they will always encounter the error: "Uncaught TypeError: Cannot call method 'replace' of undefined" googleanalytics.js:11.

This occurs when a link is clicked. This occurs because the escapeDomains function is expecting a domain (text) when in fact it receives an undefined.

I think that if a user doesn't list anything in the textarea and they have "A single domain" selected, then that domain should automatically be used. This would stop users from having to come back and make changes when they switch from a development environment to production.

Comment	File	Size	Author
#19	1113550+JavaScript+Uncaught+TypeError+Cannot+call+method+replace.patch	4.48 KB	hass
#17	1113550+JavaScript+Uncaught+TypeError+Cannot+call+method+replace.patch	4.47 KB	hass
#14	1113550+JavaScript+Uncaught+TypeError+Cannot+call+method+replace.patch	3.46 KB	hass
#13	1113550+JavaScript+Uncaught+TypeError+Cannot+call+method+replace.patch	3.46 KB	hass
#12	1113550+JavaScript+Uncaught+TypeError+Cannot+call+method+replace.patch	3.46 KB	hass
#11	1113550+JavaScript+Uncaught+TypeError+Cannot+call+method+replace.patch	1.01 KB	hass

Comments

Comment #1

hass commented 13 April 2011 at 20:42

Title:

Top Level Domain List Requirement

» JavaScript: Uncaught TypeError - Cannot call method 'replace' of undefined

Comment #2

hass commented 13 April 2011 at 20:43

#1126462: Javascript error has eben marked as duplicate.

Comment #3

13rac1 commented 26 April 2011 at 22:49

sub.

Temporary Workaround: Select "Multiple top-level domains" and add dev and production domains to the "List of top-level domains".

Comment #4

hass commented 1 May 2011 at 17:49

Status:

Active

» Postponed (maintainer needs more info)

Can you guys verify if you are really running the 1.2?

I'm trying to reproduce this myself with Google Chrome and Firefox 4 with Firebug for about 1 hour, but no luck. Can you give me a hint how I'm able to see the error message, please?

Comment #5

13rac1 commented 1 May 2011 at 18:00

Status:

Postponed (maintainer needs more info)

» Active

Hass,
I realize I've only been seeing the error in a specific browser...

Start Internet Explorer. :-/ I was running IE8 with compatibility mode enabled most often.
Click any link, and you'll see an error message icon appear momentarily. It is easier to catch the error by clicking an AJAX enabled link or probably even an anchor, so the page doesn't refresh.

Comment #6

codeamatic commented 16 May 2011 at 20:55

I too, have only been seeing this error in the IE browsers.

Comment #7

altrugon commented 27 June 2011 at 16:22

I can verify this is only happening on IE browsers on line #11

  RegExp.escapeDomains = function(text) {
11    return text.replace(/[-[\]{}()*+?.,\\^$#\s]/g, "\\$&");
  }

but the call to this function is coming from line #27

var isCrossDomain = new RegExp("^(https?|ftp|news|nntp|telnet|irc|ssh|sftp|webcal):\/\/.*(" + RegExp.escapeDomains(ga.trackCrossDomains) + ")", "i");

Comment #8

varunarora commented 13 August 2011 at 21:53

This might be a stupid hackish temporary fix, but before line 27, try inserting:

if (ga.trackCrossDomains) var crossDomainVal = RegExp.escapeDomains(ga.trackCrossDomains); else var crossDomainVal = '';

I do not know how the module works - so I do not know if this damaging to the current functionality or not. eosrei's fix is not working as well as expected, because it messes around with the behavior of regular external links