I've been doing some work for a couple websites recently that have been using this module, and it seems I've had to fix a bunch of little things in it get it working right.

I believe I have fixed these issues:
- http://drupal.org/node/799282 - Line 50 of the existing version of views_fluidgrid.module was passing in false where undefined was expected
- http://drupal.org/node/875136 - discovered an error in the jquery.masonry.min.js (after unminifying it, so there's an unminified version of the javascript in this zip if you want one to debug with) where it was checking "if(opts.singleMode)" instead of "if(opts.singleMode == true)" which was forcing the module to always use single mode. That one little change lets you have blocks of different widths in the layout now
- Created a separate fluidgrid.js file to deal with the section in the module file labeled "This looks like shit!" now the inline javascript just stores the id and the drupal settings in an object, and then if Drupal exists in runs a function from fluidgrid.js that does what the old inline script used to do. fluidgrid.js also checks if the object created by the inline code exists, and will run the function on it if it does. This way, the module code is a bit cleaner, you can load your javascript in the header or at the end of the body, and if I'm not mistaken it should all still work with AJAX.

When this project comes out of crunch time, I'll try and figure out how to make a patch for a whole directory, but until then, here's a zip file.

CommentFileSizeAuthor
views_fluidgrid_little_fixes.zip13.73 KBcyborg_572

Comments

paulgemini’s picture

Thanks for doing this!

Marko B’s picture

Category: task » bug
Priority: Normal » Major

I tried your fixes, even uninstalled old one and put this one and still keep getting images stacked over in chrome, added attachment here to see. http://drupal.org/node/1038084#comment-5440088 can post code if needed to solve this issue.