Closed (fixed)
Project:
Ubercart Product Keys
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
2 Apr 2011 at 02:31 UTC
Updated:
15 May 2016 at 15:27 UTC
Jump to comment: Most recent
Comments
Comment #1
freixas commentedPlans, yes. Work, no.
The theory is that I just run this through some module and presto—I have D7 code! Anyone want to volunteer to try to create that patch?
I don't believe there are any architectural changes that I want to make to this module. One caveat: the sample package needs to be converted and tested as well.
Comment #2
jlemosy commentedShoot, this is something I could *really* use for the newest version of Ubercart (7.x-3.0). I wish I had the necessary programming skills to help, but that's unfortunately not my field of expertise. I'll be excited to hear about any progress toward a D7 version!
Comment #3
cmcintosh commentedIll take a look at this in the next day or so as I have a client i am moving into d7 soon.
Comment #4
roam2345 commentedCreated a D7 project for commerce http://drupal.org/project/commerce_product_key the basic use case is working right now only.
Comment #5
cmcintosh commented@jucallme Unrelated, but thanks
Comment #6
gentl.ice commentedany news about progress development ver.d7?
Comment #7
kevinquillen commentedsubscribe
Comment #8
freixas commentedUpdate: I have done no work toward a D7 release nor has anyone sent me a patch. For a while, it looked like the Ubercart project had been abandoned, but there is a beta release of Ubercart 3 out right now. The Drupal project site for Ubercart seems active, but the Ubercart web site seems abandoned.
There's been some talk of Drupal Commerce as the ecommerce path for anyone using D6/Ubercart2 and wanting to move to D7, but that seems like a pretty big jump and, to be honest, I'm a bit put off by the if-you-won't-do-it-my-way-we'll-just-fork attitude—duplication of effort is discouraged for contributing modules.
As posted above, someone has implemented something for D7/Drupal Commerce. As for my development of a D7 version, it will probably happen when I need this module for a D7 installation, which means it won't happen anytime soon. If you need a D7 version, consider creating and testing a D7 version yourself or hiring someone to do it and then submit a patch.
You could hire me, of course. Think about how many hours it would take to prepare a Drupal 7 installation for testing, create the D7 module, verify that all the features still work, update the documentation, learn Git, create the D7 branch, check it all in and announce the changes. Multiply by US$70. If you've got that much loose cash, send me a message. :-)
Comment #9
samgreco commentedI really could use something like this. I need a module to deal with serial numbers for products. Not generated, but actual serial numbers that need to be tracked. It looks like this could do it. Except of course, I have D7-UC3.
What would it take to get you do convert this module? Please PM me with costs and let's see if we can make it happen.
Comment #10
cmejo commentedJust posting to say I support a D7 upgrade! I'm debating whether to use Ubercart or Commerce, but I would require this functionality. If I can help in some way, let me know!
Comment #11
freixas commentedThanks for the offer. You (or anyone) could help by doing the port and testing it.
See Comment #8.
Comment #12
vip3rousmango commentedCame across this module while doing some research for a Drupal 7 Ubercart product activation issue.
I would be willing to help with the port from 6 to 7 as the features in the module are exactly what I'm looking for.
Has any progress on a d7 port happened since this thread was updated?
Do you think this module could translate over using the Coder module to help facilitate the port from 6 to 7?
Reading post #8 above, would you have an estimated cost of conversion if it came down to that, in the off chance I'm not able to figure porting it myself?
Thanks!
Comment #13
freixas commentedHello,vip3rousmango,
Sounds great, but realistically, if you go down this path, you should have the mindset that you will do the entire thing on your own.
No progress on a D7 port has occurred.
I believe there are some tools that will help kickstart the conversion from D6 to D7 and from U2 to U3 (it's not just a Drupal upgrade, Ubercart has been updated as well).
As for an estimate, all I can do is repeat: Think about how many hours it would take to prepare a Drupal 7 installation for testing, create the D7 module, verify that all the features still work, update the documentation, learn Git, create the D7 branch, check it all in and announce the changes. Multiply by US$70.
If the number sounds like something you can afford, then contact me directly and we can talk about it.
Let me know if you have any success. Good luck!
Comment #14
cmcintosh commentedI dont have a customer atm that needs this and my plate is full atm, but I would suggest if you do upgrade that you should probably consider changing this module to allow it to use the entity api / field api systems. Just a suggestion, with the advent of rules into uc3 actually issuing the keys should not be a terrible difficult issue. I encourage you to get started if you have questions let me know and i will provide feedback as i can.
Maintainer can we get a d-7 dev branch going here?
Comment #15
freixas commentedHi, cmcintosh,
Thanks for the suggestion. Part of the reason I haven't done the upgrade is that I not only haven't had a need for this module in a long time, I haven't even had a need for Drupal. As soon as you talk about having to learn a new API, my brain futzes out. I've heard about Entities, but don't know a thing about them other than the name. Nor have I worked with UC3 or looked at the rule system. Hopefully, if someone tackles the upgrade, your suggestions will make sense to them. If this is the right way to go, I have no problems with it.
Another blocker is that I don't have much experience with Git. I think there should now be a 7.x-1.x branch, but I won't swear to it!
Comment #16
cmcintosh commentedIf you would like to set me up as a co maintainer i could help with that or if you dont have any time for it all i think i could fit it into my small family of contrib work that i maintain. Let me know either way.
Comment #17
freixas commentedI don't have a problem with adding a co-maintainer, but could you be specific about what you are volunteering for? In other words, are you volunteering to handle just creating/managing branches/releases? Installing patches? Coding? Testing? Or...?
Comment #18
cmcintosh commentedmy process for upgrading the module to d7 would be to really start from scratch, build out a SimpleTest test for the module so that we maintain functionality that we had in D6, then create the module, and finally create a migration script to move data from drupal 6 to drupal 7.
My use for this back when i used it was for a couple of customers who were software developers and wanted to setup a web based authentication / registration for their software that desktop apps could connect to, so maybe it would be good to extend the module and create sorts of api to allow for that to be done easier.
Comment #19
freixas commentedEveryone finds it easier to write things from scratch. I've reinvented the wheel a number of times myself, but I'm not in favor of a reinvention here. Sorry—you'd first have the make a good technical case for a re-write.
As for providing extensions to make the authentication easier, that sounds fine. The module is already set up to handle these extensions. The reason I didn't include any more assistance is because I don't know about all the various methods for getting and validating licenses. If there is a system/process that is in wide use or that can be applied to different licensing solutions, then great.
The addition of SimpleTest tests would be an excellent thing to do.
It sounded a few messages ago like your plate was already full. I'm still not exactly sure what you propose bringing to the table as a co-maintainer. Perhaps we can discuss this directly and see what makes sense.
Comment #20
cmcintosh commentedWhat I mean with starting from scratch is by implementing the new Entity API + Field API, versus a standard form + database table like it is now. The benefit of doing it this way is that it makes it a lot more flexible with low cost to us and to the end developer.
I have spun up a new dev site for the purpose of building out the module, like i mentioned first steps is taking and building the tests that will allow me to upgrade the module easier. the url for the dev site will be uckeys.wembassy.com.
Comment #21
vip3rousmango commented@cmcintosh
I would agree adding support for the Entity API & Field API is a needed item if wanting to bring this module into D7!
Is the dev site open for us to check out? Thanks for taking the first steps on this.
Cheers,
Vip3rousmango
Comment #22
drummondf commentedHas there been any headway here? I am in need of this module. Would like to see if a dev version is available for 7 yet?
I am possibly interested in paying for dev
Comment #23
keithm commentedI have ported this module to Drupal 7. It is a pretty direct port without any unnecessary changes. I would be willing to push it to a 7.x-1.x branch here and make it available to anyone who wants to try it. FYI here is my commit log.
140cda1 by keithm: Cleaned up some documentation todos.
0d449c3 by keithm: Fixed unbound property warning in theme_uc_product_keys_list_form().
17bc8f5 by keithm: Added missing variable assignment in uc_product_keys_db_update_key().
ea30f10 by keithm: Fixed missing variable typo in uc_product_keys_cache_clear().
dc8c7a4 by keithm: Removed some unused local variables.
a928532 by keithm: Fixed missing variable typo in uc_product_keys_list_form_submit().
7598722 by keithm: Converted to hook_uc_order() for Ubercart-7.x.
6e09875 by keithm: Added uc_product_keys_uc_message() for email message body.
61d0193 by keithm: Converted token support for D7.
878efe1 by keithm: Converted uc_product_keys_mail() for D7.
6283fcb by keithm: Replace conditional action trigger by rules event invocation.
b7904c8 by keithm: Added default 'E-mail product keys to a customer' rule.
44e75ab by keithm: Converted conditional action hook implementations to rules hooks.
9059335 by keithm: Renamed uc_product_keys.ca.inc => uc_product_keys.rules.inc.
942df90 by keithm: Changed uc_product_keys_sample to use D7 database API syntax.
530dcfe by keithm: Fixed uc_product_keys_import_form_submit() to use D7 file interface.
1ab8bf1 by keithm: Fixed uc_product_keys_db_assign_keys() to use D7 database API syntax.
9670016 by keithm: Fixed uc_product_keys_db_get_all_seq_prod() to use D7 database API syntax.
535a740 by keithm: Fixed uc_product_keys_db_get_key_by_product_key() to use D7 database API syntax.
9e5cb2f by keithm: Fixed uc_product_keys_db_get_key() to use D7 database API syntax.
26b9d0a by keithm: Fixed uc_product_keys_list_form_submit() to use drupal_goto D7 options syntax.
b88726d by keithm: Fixed uc_product_keys_list_sequences_form_submit() to use drupal_goto D7 options syntax.
132ab6b by keithm: Converted uc_product_keys_db_get_keys() to D7 database API syntax.
1d95ad5 by keithm: Removed dead code in uc_product_keys_db_get_product_for_sequence().
34de6a9 by keithm: Fixed require_once path.
f83c2a2 by keithm: Converted uc_product_keys_nodeapi() into D7 node API hook implementations.
252631e by keithm: Reviewed conversion of uc_product_keys_sample_uninstall() to D7 database API syntax.
cee6ba0 by keithm: Reviewed conversion of uc_product_keys_set_stock() to D7 database API syntax.
cf4bc94 by keithm: Reviewed conversion of uc_product_keys_db_disassociate_keys_from_order() to D7 database API syntax.
4247c24 by keithm: Reviewed conversion of uc_product_keys_db_disassociate_keys_from_user() to D7 database API syntax.
3018b70 by keithm: Reviewed conversion of uc_product_keys_db_disassociate_keys_from_product() to D7 database API syntax.
7593b4e by keithm: Converted uc_product_keys_db_increment_activation() to D7 database API syntax.
38c1306 by keithm: Reviewed conversion of uc_product_keys_db_delete_key() to D7 database API syntax.
19266f3 by keithm: Reviewed conversion of uc_product_keys_db_disassociate_sequence_from_product() to D7 database API syntax.
26911b5 by keithm: Changed uc_product_keys_db_delete_sequence() to use D7 database API syntax.
2e497c8 by keithm: Reviewed converted uc_product_keys_permission().
d2dd64c by keithm: Reviewed converted uc_product_keys_uninstall().
8d819f4 by keithm: Reviewed converted uc_product_keys_install().
99cb162 by keithm: Reviewed converted call to check_markup().
6ba7bdf by keithm: Reviewed converted call to user_load().
85040d5 by keithm: Automatically converted by coder_upgrade.
914cac5 by keithm: Removed initial underscore from private functions to allow coder_upgrade to work.
Comment #24
keithm commentedThere is now a uc_product_keys-7.x-1.x development release. Please check it out.
Comment #25
keithm commented