As described on http://drupal.org/node/11812, the $layout variable should be set to 'none' if there are no sidebars. Right now, the PHPTemplate engine uses $show_blocks, which defaults to TRUE, to determine if $layout variable should be set to 'none'. It appears as though $show_blocks is only set to FALSE in certain situations (drupal_not_found() for example).

CommentFileSizeAuthor
#3 layout_none_0.patch1 KBax
layout_none.patch725 bytesWill White

Comments

Will White’s picture

Will White commented
Status: Active » Needs review
adrinux’s picture

adrinux commented

I didn't find this issue and submitted a dupe http://drupal.org/node/121576 but have now marked that a dupe of this issue.

+1 for this patch

I can confirm reverting to setting a default value for $layout as we did before the blocks patch http://drupal.org/node/80201 was applied fixes this problem in Drupal-5.1

ax’s picture

ax commented
StatusFileSize
new layout_none_0.patch1 KB

this can be done better, see attached. removes 3 lines of code and the "notice: Undefined variable: layout in /var/www/drupal-cvs/themes/engines/phptemplate/phptemplate.engine on line 179."

ax’s picture

ax commented
Status: Needs review » Fixed

this apparently got silently applied to both HEAD and 5. because there was a later duplicate bug report that somehow got noticed first. well, anyway - marking this FIXED.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)