Closed (fixed)
Project:
Media Field
Version:
4.7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
22 Jan 2007 at 02:51 UTC
Updated:
10 Feb 2007 at 15:25 UTC
Jump to comment: Most recent file
Is anyone already working on porting this to Drupal 5.0? I have gone through and done a lot of the work already though I haven't tested it yet. I should finish it in the next day or two once I have had a chance to test it.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | mediafield-5.x-dev.xls | 11.35 KB | scafmac |
| #3 | patch_95.txt | 20.55 KB | scafmac |
Comments
Comment #1
ardas commentedAs I know, noone is working. I was busy with some other stuff and had no chance to port it to Drupal 5.0. If you have already done a lot of work I'll not start this task.
Please, upload your 5.0 version when it is ready to this specially created issue http://drupal.org/node/112079, I'll make a code review and create a release then.
Thank you.
Comment #2
ardas commentedSorry :) I've confused tasks and created a superfluous issue. I've closed it already. Just upload 5.0 version to this issue. Thanks!
Comment #3
scafmac commentedActually now that I'm actually testing it, I've hit a bit of a road block. I'm happy to upload the changes I've made, mainly just making styles standard, but also a few renamed functions and I found a bug or two, but it isn't working. I'm not sure the module is going to do what I need any way, so it might be better if you take what I've done and run with it.
Attached is a patch with all of the changes including two new .info files. They need to have the correct id lines added to the top of the file.
The problem I ran into was that when uploading a new audio file, it would act like it was uploading, but nothing would appear on the form or in the files directory. I tried debugging it, but I don't understand CCK well enough to be very productive at it. I hope the code helps a bit.
If you don't have much time, but have some suggestions, I'd be happy to keep plugging away at it some, I'm just at a loss of what to try now.
Comment #4
ardas commentedThanks. I'll study it.
Could you please upload 5.0 version itself also - that would be easier for me to compare it with my one.
Thank you.
Comment #5
scafmac commentedIt will not let me upload a tar.gz file. So although this has an xls extension, it is really a gzipped tar file.
Comment #6
ardas commentedThank you a lot for your work. I have reviewed everything and commited all changes to the HEAD revision.
There is a question concerning file_check_upload() usage:
why did you do
instead of
?
Comment #7
ardas commentedI've removed HEAD release from the site because it is not yet ready. We continue developing it ...
Comment #8
maastrix commentedsubscribing.. looking and waiting for this for months now...
Comment #9
scafmac commentedHey there - ya, I don't know what I was trying to do there. I was working on patches to the coder module while I was working on MediaField. Coder does some regular expression matches for syntax warnings. It was probably an unfixed test case. Sorry about that.
Comment #10
ardas commentedWe did some work with these media fields and commited it into 5.0 and HEAD.
Please, download 5.0 release and try it. We fixed several major defects and added several features.
Comment #11
ardas commented